Message-ID: <52F49E12.4090102@metafoo.de>
Date: Fri, 07 Feb 2014 09:49:22 +0100
From: Lars-Peter Clausen <lars@metafoo.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: Jingoo Han <jg1.han@samsung.com>
CC: "'Andrew Morton'" <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        "'Alessandro Zummo'" <a.zummo@towertech.it>,
        rtc-linux@googlegroups.com,
        "'Thierry Reding'" <thierry.reding@gmail.com>
Subject: Re: [PATCH 3/4] rtc: rtc-jz4740: Use devm_ioremap_resource()
References: <000401cf23d9$d1df6e30$759e4a90$%han@samsung.com> <000701cf23da$688e1b60$39aa5220$%han@samsung.com> <52F495A4.70400@metafoo.de> <001801cf23de$f1b708d0$d5251a70$%han@samsung.com>
In-Reply-To: <001801cf23de$f1b708d0$d5251a70$%han@samsung.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 02/07/2014 09:31 AM, Jingoo Han wrote:
> On Friday, February 07, 2014 5:13 PM, Lars-Peter Clausen wrote:
>> On 02/07/2014 08:58 AM, Jingoo Han wrote:
>> [...]
>>> -	rtc->base = devm_ioremap_nocache(&pdev->dev, rtc->mem->start,
>>> -					resource_size(rtc->mem));
>>> -	if (!rtc->base) {
>>> -		dev_err(&pdev->dev, "Failed to ioremap mmio memory\n");
>>> -		return -EBUSY;
>>> -	}
>>> +	mem->flags &= ~IORESOURCE_CACHEABLE;
>>
>> You shouldn't be modifying the resource, strictly speaking it is not owned
>> by the device. And IORESOURCE_CACHEABLE is never set for this device anyway.
>
> (+cc Thierry Reding)
>
> Hi Lars-Peter Clausen,
>
> Do you mean that resource's flags should NOT be modified by the
> device driver, right?
> Then, without 'mem->flags &= ~IORESOURCE_CACHEABLE', is it possible
> that devm_ioremap_nocache() can be called at devm_ioremap_resource()?
>

Yes. ioremap_nocache() will be called, when the flag is not set, 
ioremap_cached() will be called when the flag is set. If the flag is set the 
intention is probably that the region should be mapped cached.

> Thierry,
> Do you have any comments on this?
>
> Thank you.
>
> Best regards,
> Jingoo Han
>
>>
>>> +	rtc->base = devm_ioremap_resource(&pdev->dev, mem);
>>> +	if (IS_ERR(rtc->base))
>>> +		return PTR_ERR(rtc->base);
>>>
>>>    	spin_lock_init(&rtc->lock);
>>>
>>>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/