Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbaBGKdL (ORCPT ); Fri, 7 Feb 2014 05:33:11 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34602 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbaBGKdJ (ORCPT ); Fri, 7 Feb 2014 05:33:09 -0500 Message-ID: <52F4B662.5070809@suse.cz> Date: Fri, 07 Feb 2014 11:33:06 +0100 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Joonsoo Kim , Andrew Morton CC: Mel Gorman , Joonsoo Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm/compaction: clean-up code on success of ballon isolation References: <1391749726-28910-1-git-send-email-iamjoonsoo.kim@lge.com> <1391749726-28910-6-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1391749726-28910-6-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2014 06:08 AM, Joonsoo Kim wrote: > It is just for clean-up to reduce code size and improve readability. > There is no functional change. > > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka > diff --git a/mm/compaction.c b/mm/compaction.c > index 985b782..7a4e3b7 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -554,11 +554,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, > if (unlikely(balloon_page_movable(page))) { > if (locked && balloon_page_isolate(page)) { > /* Successfully isolated */ > - cc->finished_update_migrate = true; > - list_add(&page->lru, migratelist); > - cc->nr_migratepages++; > - nr_isolated++; > - goto check_compact_cluster; > + goto isolate_success; > } > } > continue; > @@ -610,13 +606,14 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, > VM_BUG_ON(PageTransCompound(page)); > > /* Successfully isolated */ > - cc->finished_update_migrate = true; > del_page_from_lru_list(page, lruvec, page_lru(page)); > + > +isolate_success: > + cc->finished_update_migrate = true; > list_add(&page->lru, migratelist); > cc->nr_migratepages++; > nr_isolated++; > > -check_compact_cluster: > /* Avoid isolating too much */ > if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) { > ++low_pfn; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/