Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbaBGLFk (ORCPT ); Fri, 7 Feb 2014 06:05:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35538 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbaBGLFj (ORCPT ); Fri, 7 Feb 2014 06:05:39 -0500 Date: Fri, 07 Feb 2014 12:05:38 +0100 Message-ID: From: Takashi Iwai To: Hsin-Yu Chao Cc: linux-arm-kernel@lists.infradead.org, Jaroslav Kysela , Dylan Reid , Chih-Chung Chang , Xi Wang , Ian Minett , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: hda/ca0132 - Fix recording from mode id 0x8 In-Reply-To: <1391744130-15043-2-git-send-email-hychao@chromium.org> References: <1391744130-15043-1-git-send-email-hychao@chromium.org> <1391744130-15043-2-git-send-email-hychao@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 7 Feb 2014 11:35:30 +0800, Hsin-Yu Chao wrote: > > The Chromebook Pixel has a microphone under the keyboard that > is attached to node id 0x8. Before this fix, recording would > always go to the main internal mic (node id 0x7). > > Signed-off-by: Hsin-Yu Chao > Reviewed-by: Dylan Reid The description doesn't state why it fixes what: the patch is actually a fix for the wrong ADC pickup in ca0132_capture_pcm_prepare() where it assumes wrongly the multiple streams although the driver implements one stream per ADC. (And, ca0132_capture_pcm_cleanup() already does the right thing.) Could you rephrase the patch description and resend? thanks, Takashi > --- > sound/pci/hda/patch_ca0132.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c > index 59104dc..d5aabce 100644 > --- a/sound/pci/hda/patch_ca0132.c > +++ b/sound/pci/hda/patch_ca0132.c > @@ -2770,9 +2770,7 @@ static int ca0132_capture_pcm_prepare(struct hda_pcm_stream *hinfo, > unsigned int format, > struct snd_pcm_substream *substream) > { > - struct ca0132_spec *spec = codec->spec; > - > - snd_hda_codec_setup_stream(codec, spec->adcs[substream->number], > + snd_hda_codec_setup_stream(codec, hinfo->nid, > stream_tag, 0, format); > > return 0; > -- > 1.9.0.rc1.175.g0b1dcb5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/