Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbaBGOtq (ORCPT ); Fri, 7 Feb 2014 09:49:46 -0500 Received: from top.free-electrons.com ([176.31.233.9]:47729 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751476AbaBGOtp (ORCPT ); Fri, 7 Feb 2014 09:49:45 -0500 Message-ID: <52F4F279.6010006@free-electrons.com> Date: Fri, 07 Feb 2014 15:49:29 +0100 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ezequiel Garcia , Jason Cooper CC: =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , Mike Turquette , Thomas Petazzoni , Andrew Lunn , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH] clk: respect the clock dependencies in of_clk_init References: <1391554766-11285-1-git-send-email-gregory.clement@free-electrons.com> <52F4DA40.4090804@elopez.com.ar> <20140207142430.GU8533@titan.lakedaemon.net> <20140207144325.GA8218@localhost> In-Reply-To: <20140207144325.GA8218@localhost> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2014 15:43, Ezequiel Garcia wrote: > On Fri, Feb 07, 2014 at 09:24:30AM -0500, Jason Cooper wrote: >> On Fri, Feb 07, 2014 at 10:06:08AM -0300, Emilio López wrote: >> >> [snip a great explanation] >> >> Guys, can I get some Tested-by's on this? >> > > In case someone missed Emilio's comment about it, I gave his oneliner > a test on A370 Reference Design. It worked just as well as Sebastian's. Well ok it's working but this patch is not better than Sebastian, it is even worth. I don't think it is a good idea at all to totally ignore the information given by the device tree. > > Tested-by: Ezequiel Garcia > >>> -----8<------ >>> >>> From ffdb49506e3ce92090c15e1f9b37f4d465097ac1 Mon Sep 17 00:00:00 2001 >>> From: =?UTF-8?q?Emilio=20L=C3=B3pez?= >>> Date: Thu, 6 Feb 2014 18:07:07 -0300 >>> Subject: [PATCH] clk: mvebu: fix name dependency during registration time >>> >>> Currently, mvebu_clk_gating_setup has a silly dependency on clock >>> registration order just to gather the parent clock name. This is >>> completely unnecesary, as it supports using an already provided name >>> via the clk_gating_soc_desc structs, and we can therefore solve this >>> issue with a 69+/- line patch. But, given that the parent name is >>> always "tclk" as default-hardcoded on mvebu_coreclk_setup(), we can >>> just default-hardcode it here too and get away with solving this >>> problem with a one-liner. >>> --- >>> drivers/clk/mvebu/common.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c >>> index 25ceccf..6c63b43 100644 >>> --- a/drivers/clk/mvebu/common.c >>> +++ b/drivers/clk/mvebu/common.c >>> @@ -121,7 +121,7 @@ void __init mvebu_clk_gating_setup(struct >>> device_node *np, >>> struct clk_gating_ctrl *ctrl; >>> struct clk *clk; >>> void __iomem *base; >>> - const char *default_parent = NULL; >>> + const char *default_parent = "tclk"; >>> int n; >>> >>> base = of_iomap(np, 0); >>> -- >>> 1.8.5.3 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/