Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbaBGPNF (ORCPT ); Fri, 7 Feb 2014 10:13:05 -0500 Received: from top.free-electrons.com ([176.31.233.9]:47903 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751463AbaBGPND (ORCPT ); Fri, 7 Feb 2014 10:13:03 -0500 Message-ID: <52F4F7EF.7090900@free-electrons.com> Date: Fri, 07 Feb 2014 16:12:47 +0100 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , Ezequiel Garcia , Jason Cooper CC: Mike Turquette , Thomas Petazzoni , Andrew Lunn , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH] clk: respect the clock dependencies in of_clk_init References: <1391554766-11285-1-git-send-email-gregory.clement@free-electrons.com> <52F4DA40.4090804@elopez.com.ar> <20140207142430.GU8533@titan.lakedaemon.net> <20140207144325.GA8218@localhost> <52F4F279.6010006@free-electrons.com> <52F4F502.2010703@elopez.com.ar> In-Reply-To: <52F4F502.2010703@elopez.com.ar> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2014 16:00, Emilio López wrote: > El 07/02/14 11:49, Gregory CLEMENT escribió: >> On 07/02/2014 15:43, Ezequiel Garcia wrote: >>> On Fri, Feb 07, 2014 at 09:24:30AM -0500, Jason Cooper wrote: >>>> On Fri, Feb 07, 2014 at 10:06:08AM -0300, Emilio López wrote: >>>> >>>> [snip a great explanation] >>>> >>>> Guys, can I get some Tested-by's on this? >>>> >>> >>> In case someone missed Emilio's comment about it, I gave his oneliner >>> a test on A370 Reference Design. It worked just as well as Sebastian's. >> >> Well ok it's working but this patch is not better than Sebastian, it is >> even worth. I don't think it is a good idea at all to totally ignore the >> information given by the device tree. > > With a bit more work, you can replace the clk_get magic with a call to > of_clk_get_parent_name() or similar to be able to keep overriding stuff > from DT. This way it would completely match the behaviour on > mvebu_coreclk_setup (default to "tclk", allow overriding with DT). > I think you didn't have a look on our implementation: the name of the clock are created by the driver during the initialization. That's why we need that the parent clock are initialized before the gating clock. I know that for the sunxi clock you choose to list all your clock name in the device tree, but we didn't make this choice on purpose. It is not as trivial as you suggested. I didn't have a look on the atmel clocks, and I don't know if they have this kind of issue, as they also have to deal with multiple parents, they may have different issues. Gregory > Emilio > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/