Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753095AbaBGRXt (ORCPT ); Fri, 7 Feb 2014 12:23:49 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:45793 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbaBGRXr convert rfc822-to-8bit (ORCPT ); Fri, 7 Feb 2014 12:23:47 -0500 X-Originating-IP: 50.43.14.201 Date: Fri, 7 Feb 2014 09:23:42 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH 3/3] sound: Move prototype declaration to header file oss/pas2.h from oss/pas2_card.c Message-ID: <20140207172341.GD7298@jtriplet-mobl1> References: <512472c7d96cf1c239ba3d0bc517891a7c2f9da1.1391791103.git.rashika.kheria@gmail.com> <3c35e9b980ccc0ca155214e8fad0dae24b20c5af.1391791103.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3c35e9b980ccc0ca155214e8fad0dae24b20c5af.1391791103.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 07, 2014 at 10:16:31PM +0530, Rashika Kheria wrote: > Move prototype declaration of function to header file oss/pas2.h > from oss/pas2_card.c because it is used by more than one file. > > This eliminates the following warnings in oss/pas2_mixer.c: > sound/oss/pas2_mixer.c:62:1: warning: no previous prototype for ‘mix_write’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > sound/oss/pas2.h | 3 +++ > sound/oss/pas2_card.c | 2 -- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sound/oss/pas2.h b/sound/oss/pas2.h > index fa12c55..d19f757 100644 > --- a/sound/oss/pas2.h > +++ b/sound/oss/pas2.h > @@ -15,3 +15,6 @@ int pas_init_mixer(void); > /* From pas_midi.c */ > void pas_midi_init(void); > void pas_midi_interrupt(void); > + > +/* From pas2_mixer.c*/ > +void mix_write(unsigned char data, int ioaddr); > diff --git a/sound/oss/pas2_card.c b/sound/oss/pas2_card.c > index 7004e24..b07954a 100644 > --- a/sound/oss/pas2_card.c > +++ b/sound/oss/pas2_card.c > @@ -74,8 +74,6 @@ static char *pas_model_names[] = { > * to support other than the default base address > */ > > -extern void mix_write(unsigned char data, int ioaddr); > - > unsigned char pas_read(int ioaddr) > { > return inb(ioaddr + pas_translate_code); > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/