Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbaBGRYC (ORCPT ); Fri, 7 Feb 2014 12:24:02 -0500 Received: from mx0.aculab.com ([213.249.233.131]:36939 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752707AbaBGRX7 convert rfc822-to-8bit (ORCPT ); Fri, 7 Feb 2014 12:23:59 -0500 From: David Laight To: "'Josh Triplett'" CC: "'Rashika Kheria'" , "linux-kernel@vger.kernel.org" , "Armin Schindler" , Karsten Keil , "netdev@vger.kernel.org" Subject: RE: [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c Thread-Topic: [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c Thread-Index: AQHPJAIZEAfhJt2pSki9/NC6TGJzyJqpydjwgAA+egCAAAFN0A== Date: Fri, 7 Feb 2014 17:22:58 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6BAC1C@AcuExch.aculab.com> References: <3cb4d7892ba5a0c0936b3a1e2c9c991a6dbc3229.1390408513.git.rashika.kheria@gmail.com> <93d7188538418423685ecefaf3d2bb311b37be6e.1390408518.git.rashika.kheria@gmail.com> <063D6719AE5E284EB5DD2968C1650D6D0F6BA76D@AcuExch.aculab.com> <20140207171516.GA7298@jtriplet-mobl1> In-Reply-To: <20140207171516.GA7298@jtriplet-mobl1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josh Triplett > On Fri, Feb 07, 2014 at 01:33:46PM +0000, David Laight wrote: > > From: Rashika Kheria > > > Move prototype declarations of function to header file > > > hardware/eicon/platform.h because they are used by more than one file. > > > > > > This eliminates the following warnings in hardware/eicon/diddfunc.c: > > > drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype for diddfunc_init [- > > > Wmissing-prototypes] > > > drivers/isdn/hardware/eicon/diddfunc.c:110:13: warning: no previous prototype for diddfunc_finit > [- > > > Wmissing-prototypes] > > ... > > > diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c > > > index fab6ccf..56d32a7 100644 > > > --- a/drivers/isdn/hardware/eicon/diva_didd.c > > > +++ b/drivers/isdn/hardware/eicon/diva_didd.c > > > @@ -39,9 +39,6 @@ MODULE_LICENSE("GPL"); > > > #define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR) > > > #define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG) > > > > > > -extern int diddfunc_init(void); > > > -extern void diddfunc_finit(void); > > > - > > > extern void DIVA_DIDD_Read(void *, int); > > > > You should move that one as well. > > There really shouldn't be 'extern' definitions for any function in > > any C files since you want the compiler to check they are correct > > when the function itself is compiled. > > Absolutely, but as far as I can tell Rashika is doing this > incrementally, organized more by header than by source file, so I'd > expect a few externs in a source file to disappear at a time rather than > all in one patch. Unless any actual bugs are found, I'd have thought a single patch for each driver would be enough, maybe even one for the whole lot - depending on how they are maintained. The 26 patches already posted are a little excessive. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/