Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbaBGRZS (ORCPT ); Fri, 7 Feb 2014 12:25:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43165 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbaBGRZR (ORCPT ); Fri, 7 Feb 2014 12:25:17 -0500 Date: Fri, 07 Feb 2014 18:25:15 +0100 Message-ID: From: Takashi Iwai To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org, josh@joshtriplett.org Subject: Re: [PATCH 1/3] sound: Include appropriate header file in pcsp/pcsp_input.c In-Reply-To: <512472c7d96cf1c239ba3d0bc517891a7c2f9da1.1391791103.git.rashika.kheria@gmail.com> References: <512472c7d96cf1c239ba3d0bc517891a7c2f9da1.1391791103.git.rashika.kheria@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 7 Feb 2014 22:11:53 +0530, Rashika Kheria wrote: > > Include appropriate header file in drivers/pcsp/pcsp_input.c because it > defines function whose prototype definitions are present in > drivers/pcsp/pcsp_input.h. > > This eliminates the following warning in drivers/pcsp/pcsp_input.c: > sound/drivers/pcsp/pcsp_input.c:42:6: warning: no previous prototype for ‘pcspkr_stop_sound’ [-Wmissing-prototypes] > sound/drivers/pcsp/pcsp_input.c:80:5: warning: no previous prototype for ‘pcspkr_input_init’ [-Wmissing-prototypes] > sound/drivers/pcsp/pcsp_input.c:110:5: warning: no previous prototype for ‘pcspkr_input_remove’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Thanks, applied all three patches. Takashi > --- > sound/drivers/pcsp/pcsp_input.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/drivers/pcsp/pcsp_input.c b/sound/drivers/pcsp/pcsp_input.c > index b874b0a..0ecf8a4 100644 > --- a/sound/drivers/pcsp/pcsp_input.c > +++ b/sound/drivers/pcsp/pcsp_input.c > @@ -16,6 +16,7 @@ > #include > #include > #include "pcsp.h" > +#include "pcsp_input.h" > > static void pcspkr_do_sound(unsigned int count) > { > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/