Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753184AbaBGRmN (ORCPT ); Fri, 7 Feb 2014 12:42:13 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41354 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbaBGRmG (ORCPT ); Fri, 7 Feb 2014 12:42:06 -0500 X-Originating-IP: 50.43.14.201 Date: Fri, 7 Feb 2014 09:41:55 -0800 From: Josh Triplett To: David Laight Cc: "'Rashika Kheria'" , "linux-kernel@vger.kernel.org" , Armin Schindler , Karsten Keil , "netdev@vger.kernel.org" Subject: Re: [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c Message-ID: <20140207174155.GG7298@jtriplet-mobl1> References: <3cb4d7892ba5a0c0936b3a1e2c9c991a6dbc3229.1390408513.git.rashika.kheria@gmail.com> <93d7188538418423685ecefaf3d2bb311b37be6e.1390408518.git.rashika.kheria@gmail.com> <063D6719AE5E284EB5DD2968C1650D6D0F6BA76D@AcuExch.aculab.com> <20140207171516.GA7298@jtriplet-mobl1> <063D6719AE5E284EB5DD2968C1650D6D0F6BAC1C@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6BAC1C@AcuExch.aculab.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 07, 2014 at 05:22:58PM +0000, David Laight wrote: > From: Josh Triplett > > On Fri, Feb 07, 2014 at 01:33:46PM +0000, David Laight wrote: > > > From: Rashika Kheria > > > > Move prototype declarations of function to header file > > > > hardware/eicon/platform.h because they are used by more than one file. > > > > > > > > This eliminates the following warnings in hardware/eicon/diddfunc.c: > > > > drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype for diddfunc_init [- > > > > Wmissing-prototypes] > > > > drivers/isdn/hardware/eicon/diddfunc.c:110:13: warning: no previous prototype for diddfunc_finit > > [- > > > > Wmissing-prototypes] > > > ... > > > > diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c > > > > index fab6ccf..56d32a7 100644 > > > > --- a/drivers/isdn/hardware/eicon/diva_didd.c > > > > +++ b/drivers/isdn/hardware/eicon/diva_didd.c > > > > @@ -39,9 +39,6 @@ MODULE_LICENSE("GPL"); > > > > #define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR) > > > > #define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG) > > > > > > > > -extern int diddfunc_init(void); > > > > -extern void diddfunc_finit(void); > > > > - > > > > extern void DIVA_DIDD_Read(void *, int); > > > > > > You should move that one as well. > > > There really shouldn't be 'extern' definitions for any function in > > > any C files since you want the compiler to check they are correct > > > when the function itself is compiled. > > > > Absolutely, but as far as I can tell Rashika is doing this > > incrementally, organized more by header than by source file, so I'd > > expect a few externs in a source file to disappear at a time rather than > > all in one patch. > > Unless any actual bugs are found, I'd have thought a single patch for > each driver would be enough, maybe even one for the whole lot - depending > on how they are maintained. > The 26 patches already posted are a little excessive. These types of patches often seem to generate a non-trivial amount of feedback (for instance, due to driver-specific organizational issues), and breaking them up by groups of warnings has tended to avoid excessive churn and review difficulty on a larger patch. Certainly as a reviewer unfamiliar with isdn, I found this patch series far easier to review than a larger patch would have been. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/