Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbaBGRmK (ORCPT ); Fri, 7 Feb 2014 12:42:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57920 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbaBGRmG (ORCPT ); Fri, 7 Feb 2014 12:42:06 -0500 Date: Fri, 7 Feb 2014 09:43:15 -0800 From: Greg Kroah-Hartman To: Peng Tao Cc: linux-kernel@vger.kernel.org, Artem Blagodarenko , Andreas Dilger Subject: Re: [PATCH v2 RESEND 6/8] staging/lustre/obdclass: remove extra break in class_process_config Message-ID: <20140207174315.GA11384@kroah.com> References: <1390397779-30975-1-git-send-email-bergwolf@gmail.com> <1390397779-30975-7-git-send-email-bergwolf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390397779-30975-7-git-send-email-bergwolf@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 22, 2014 at 09:36:17PM +0800, Peng Tao wrote: > From: Artem Blagodarenko > > This is only part of the original Lustre commit, splitted to do the > cleanup work. > > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3155 > Lustre-change: http://review.whamcloud.com/6025 > Signed-off-by: Artem Blagodarenko > Reviewed-by: Andreas Dilger > Reviewed-by: Emoly Liu > Signed-off-by: Peng Tao > Signed-off-by: Andreas Dilger > --- > .../staging/lustre/lustre/obdclass/obd_config.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c b/drivers/staging/lustre/lustre/obdclass/obd_config.c > index 27f56c0..fd08f1d 100644 > --- a/drivers/staging/lustre/lustre/obdclass/obd_config.c > +++ b/drivers/staging/lustre/lustre/obdclass/obd_config.c > @@ -1226,24 +1226,20 @@ int class_process_config(struct lustre_cfg *lcfg) > case LCFG_POOL_NEW: { > err = obd_pool_new(obd, lustre_cfg_string(lcfg, 2)); > GOTO(out, err = 0); > - break; This confuses the static checkers. Just fix up the GOTO logic (hint, remove it!) and then it will be "obvious" that the break can go away. But for now, please leave it, unless you want to have someone just put it back... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/