Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbaBHBxI (ORCPT ); Fri, 7 Feb 2014 20:53:08 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:55665 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbaBHBxH (ORCPT ); Fri, 7 Feb 2014 20:53:07 -0500 MIME-Version: 1.0 In-Reply-To: <20140207174315.GA11384@kroah.com> References: <1390397779-30975-1-git-send-email-bergwolf@gmail.com> <1390397779-30975-7-git-send-email-bergwolf@gmail.com> <20140207174315.GA11384@kroah.com> From: Peng Tao Date: Sat, 8 Feb 2014 09:52:44 +0800 Message-ID: Subject: Re: [PATCH v2 RESEND 6/8] staging/lustre/obdclass: remove extra break in class_process_config To: Greg Kroah-Hartman Cc: Linux Kernel Mailing List , Artem Blagodarenko , Andreas Dilger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 8, 2014 at 1:43 AM, Greg Kroah-Hartman wrote: > On Wed, Jan 22, 2014 at 09:36:17PM +0800, Peng Tao wrote: >> From: Artem Blagodarenko >> >> This is only part of the original Lustre commit, splitted to do the >> cleanup work. >> >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3155 >> Lustre-change: http://review.whamcloud.com/6025 >> Signed-off-by: Artem Blagodarenko >> Reviewed-by: Andreas Dilger >> Reviewed-by: Emoly Liu >> Signed-off-by: Peng Tao >> Signed-off-by: Andreas Dilger >> --- >> .../staging/lustre/lustre/obdclass/obd_config.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c b/drivers/staging/lustre/lustre/obdclass/obd_config.c >> index 27f56c0..fd08f1d 100644 >> --- a/drivers/staging/lustre/lustre/obdclass/obd_config.c >> +++ b/drivers/staging/lustre/lustre/obdclass/obd_config.c >> @@ -1226,24 +1226,20 @@ int class_process_config(struct lustre_cfg *lcfg) >> case LCFG_POOL_NEW: { >> err = obd_pool_new(obd, lustre_cfg_string(lcfg, 2)); >> GOTO(out, err = 0); >> - break; > > This confuses the static checkers. Just fix up the GOTO logic (hint, > remove it!) and then it will be "obvious" that the break can go away. > But for now, please leave it, unless you want to have someone just put > it back... Got it. Thanks, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/