Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbaBHUKc (ORCPT ); Sat, 8 Feb 2014 15:10:32 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43149 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbaBHUK1 convert rfc822-to-8bit (ORCPT ); Sat, 8 Feb 2014 15:10:27 -0500 X-Originating-IP: 50.43.14.201 Date: Sat, 8 Feb 2014 12:10:18 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Gao feng , Sasha Levin , Andrew Morton , Steffen Hurrle , Jiri Pirko , netdev@vger.kernel.org, linux-decnet-user@lists.sourceforge.net Subject: Re: [PATCH 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Message-ID: <20140208201018.GF20885@leaf> References: <6f029c895035908595957fb16ab445c82793c77d.1391888654.git.rashika.kheria@gmail.com> <46f32476c8361e104aa27cebb3425b4926f5ad57.1391888654.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <46f32476c8361e104aa27cebb3425b4926f5ad57.1391888654.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 09, 2014 at 01:28:07AM +0530, Rashika Kheria wrote: > Move prototype declaration of functions to header file include/net/dn_route.h > from net/decnet/af_decnet.c because it is used by more than one file. > > This eliminates the following warning in net/decnet/dn_route.c: > net/decnet/dn_route.c:629:5: warning: no previous prototype for ‘dn_route_rcv’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > include/net/dn_route.h | 2 ++ > net/decnet/af_decnet.c | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/dn_route.h b/include/net/dn_route.h > index b409ad6..55df993 100644 > --- a/include/net/dn_route.h > +++ b/include/net/dn_route.h > @@ -20,6 +20,8 @@ int dn_route_output_sock(struct dst_entry __rcu **pprt, struct flowidn *, > struct sock *sk, int flags); > int dn_cache_dump(struct sk_buff *skb, struct netlink_callback *cb); > void dn_rt_cache_flush(int delay); > +int dn_route_rcv(struct sk_buff *skb, struct net_device *dev, > + struct packet_type *pt, struct net_device *orig_dev); > > /* Masks for flags field */ > #define DN_RT_F_PID 0x07 /* Mask for packet type */ > diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c > index 2954dcb..24d9193 100644 > --- a/net/decnet/af_decnet.c > +++ b/net/decnet/af_decnet.c > @@ -2104,8 +2104,6 @@ static struct notifier_block dn_dev_notifier = { > .notifier_call = dn_device_event, > }; > > -extern int dn_route_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *); > - > static struct packet_type dn_dix_packet_type __read_mostly = { > .type = cpu_to_be16(ETH_P_DNA_RT), > .func = dn_route_rcv, > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/