Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbaBHULc (ORCPT ); Sat, 8 Feb 2014 15:11:32 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36622 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbaBHUL3 convert rfc822-to-8bit (ORCPT ); Sat, 8 Feb 2014 15:11:29 -0500 X-Originating-IP: 50.43.14.201 Date: Sat, 8 Feb 2014 12:11:21 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Gao feng , Sasha Levin , Andrew Morton , Steffen Hurrle , Jiri Pirko , netdev@vger.kernel.org, linux-decnet-user@lists.sourceforge.net Subject: Re: [PATCH 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Message-ID: <20140208201120.GG20885@leaf> References: <6f029c895035908595957fb16ab445c82793c77d.1391888654.git.rashika.kheria@gmail.com> <45e9dd39b342bfb2308b75bd2b539de2c63bd6cb.1391888654.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <45e9dd39b342bfb2308b75bd2b539de2c63bd6cb.1391888654.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 09, 2014 at 01:29:55AM +0530, Rashika Kheria wrote: > Move prototype declaration of functions to header file include/net/dn.h > from net/decnet/af_decnet.c because they are used by more than one file. > > This eliminates the following warning in net/decnet/af_decnet.c: > net/decnet/sysctl_net_decnet.c:354:6: warning: no previous prototype for ‘dn_register_sysctl’ [-Wmissing-prototypes] > net/decnet/sysctl_net_decnet.c:359:6: warning: no previous prototype for ‘dn_unregister_sysctl’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > include/net/dn.h | 2 ++ > net/decnet/af_decnet.c | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/net/dn.h b/include/net/dn.h > index ccc1558..913b73d 100644 > --- a/include/net/dn.h > +++ b/include/net/dn.h > @@ -200,6 +200,8 @@ static inline void dn_sk_ports_copy(struct flowidn *fld, struct dn_scp *scp) > } > > unsigned int dn_mss_from_pmtu(struct net_device *dev, int mtu); > +void dn_register_sysctl(void); > +void dn_unregister_sysctl(void); > > #define DN_MENUVER_ACC 0x01 > #define DN_MENUVER_USR 0x02 > diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c > index 24d9193..4c04848 100644 > --- a/net/decnet/af_decnet.c > +++ b/net/decnet/af_decnet.c > @@ -2351,9 +2351,6 @@ static const struct proto_ops dn_proto_ops = { > .sendpage = sock_no_sendpage, > }; > > -void dn_register_sysctl(void); > -void dn_unregister_sysctl(void); > - > MODULE_DESCRIPTION("The Linux DECnet Network Protocol"); > MODULE_AUTHOR("Linux DECnet Project Team"); > MODULE_LICENSE("GPL"); > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/