Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbaBHUmg (ORCPT ); Sat, 8 Feb 2014 15:42:36 -0500 Received: from mail-oa0-f49.google.com ([209.85.219.49]:55612 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbaBHUme (ORCPT ); Sat, 8 Feb 2014 15:42:34 -0500 MIME-Version: 1.0 In-Reply-To: <20140208012225.d7a311c7.billfink@mindspring.com> References: <1391802529-29861-1-git-send-email-marek@goldelico.com> <20140208012225.d7a311c7.billfink@mindspring.com> Date: Sat, 8 Feb 2014 21:42:33 +0100 Message-ID: Subject: Re: [PATCH] net: rfkill-regulator: Add devicetree support. From: Belisko Marek To: Bill Fink Cc: Rob Herring , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Rob Landley , linville , johannes , davem , Grant Likely , NeilBrown , "Dr. H. Nikolaus Schaller" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , LKML , linux-wireless@vger.kernel.org, netdev Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 8, 2014 at 7:22 AM, Bill Fink wrote: > On Fri, 7 Feb 2014, Marek Belisko wrote: > >> Signed-off-by: NeilBrown >> Signed-off-by: Marek Belisko >> --- >> Based on Neil's patch and extend for documentation and bindings include. >> >> .../bindings/net/rfkill/rfkill-relugator.txt | 28 ++++++++++++++++ > > ^^^^^^^^^ > Typo in file name. Ah. Right. Thanks. > > -Bill > > > >> include/dt-bindings/net/rfkill-regulator.h | 23 +++++++++++++ I also think this should be renamed to rfkill.h because same defines could be used for rfkill-gpio driver. >> net/rfkill/rfkill-regulator.c | 38 ++++++++++++++++++++++ >> 3 files changed, 89 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/rfkill/rfkill-relugator.txt >> create mode 100644 include/dt-bindings/net/rfkill-regulator.h >> >> diff --git a/Documentation/devicetree/bindings/net/rfkill/rfkill-relugator.txt b/Documentation/devicetree/bindings/net/rfkill/rfkill-relugator.txt >> new file mode 100644 >> index 0000000..cdb7dd7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/rfkill/rfkill-relugator.txt >> @@ -0,0 +1,28 @@ >> +Regulator consumer for rfkill devices >> + >> +Required properties: >> +- compatible : Must be "rfkill-regulator". >> +- label : Name of rfkill device. >> +- type : Type of rfkill device. >> + >> +Possible values (defined in include/dt-bindings/net/rfkill-regulator.h): >> + RFKILL_TYPE_ALL >> + RFKILL_TYPE_WLAN >> + RFKILL_TYPE_BLUETOOTH >> + RFKILL_TYPE_UWB >> + RFKILL_TYPE_WIMAX >> + RFKILL_TYPE_WWAN >> + RFKILL_TYPE_GPS >> + RFKILL_TYPE_FM >> + RFKILL_TYPE_NFC >> + >> +- vrfkill-supply - regulator device. >> + >> +Example: >> + gps-rfkill { >> + compatible = "rfkill-regulator"; >> + label = "GPS"; >> + type = ; >> + vrfkill-supply = <®>; >> + }; >> + BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/