Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbaBINFI (ORCPT ); Sun, 9 Feb 2014 08:05:08 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53582 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbaBINFH convert rfc822-to-8bit (ORCPT ); Sun, 9 Feb 2014 08:05:07 -0500 X-Originating-IP: 50.43.14.201 Date: Sun, 9 Feb 2014 05:04:56 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Christine Caulfield , David Teigland , cluster-devel@redhat.com Subject: Re: [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Message-ID: <20140209130456.GA30767@leaf> References: <00380d95bfae6200d6120f050540236dbd1fc99b.1391949868.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <00380d95bfae6200d6120f050540236dbd1fc99b.1391949868.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 09, 2014 at 06:19:17PM +0530, Rashika Kheria wrote: > Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it > contains function prototypes of some functions defined in fs/dlm/ast.c. > > This also eliminates the following warning in fs/dlm/ast: > fs/dlm/ast.c:52:5: warning: no previous prototype for ‘dlm_add_lkb_callback’ [-Wmissing-prototypes] > fs/dlm/ast.c:113:5: warning: no previous prototype for ‘dlm_rem_lkb_callback’ [-Wmissing-prototypes] > fs/dlm/ast.c:174:6: warning: no previous prototype for ‘dlm_add_cb’ [-Wmissing-prototypes] > fs/dlm/ast.c:212:6: warning: no previous prototype for ‘dlm_callback_work’ [-Wmissing-prototypes] > fs/dlm/ast.c:267:5: warning: no previous prototype for ‘dlm_callback_start’ [-Wmissing-prototypes] > fs/dlm/ast.c:278:6: warning: no previous prototype for ‘dlm_callback_stop’ [-Wmissing-prototypes] > fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’ [-Wmissing-prototypes] > fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > fs/dlm/ast.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c > index 0e90f0c..42794c0 100644 > --- a/fs/dlm/ast.c > +++ b/fs/dlm/ast.c > @@ -14,6 +14,7 @@ > #include "dlm_internal.h" > #include "lock.h" > #include "user.h" > +#include "ast.h" > > static uint64_t dlm_cb_seq; > static DEFINE_SPINLOCK(dlm_cb_seq_spin); > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/