Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 3 Nov 2002 09:26:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 3 Nov 2002 09:26:52 -0500 Received: from phoenix.infradead.org ([195.224.96.167]:52229 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id ; Sun, 3 Nov 2002 09:26:50 -0500 Date: Sun, 3 Nov 2002 14:33:20 +0000 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Linus Torvalds , Linux Kernel Development Subject: Re: [PATCH] NCR53C9x ESP: C99 designated initializers Message-ID: <20021103143320.A25170@infradead.org> Mail-Followup-To: Christoph Hellwig , Geert Uytterhoeven , Linus Torvalds , Linux Kernel Development References: <20021103131339.A22465@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from geert@linux-m68k.org on Sun, Nov 03, 2002 at 03:28:55PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 21 On Sun, Nov 03, 2002 at 03:28:55PM +0100, Geert Uytterhoeven wrote: > On Sun, 3 Nov 2002, Christoph Hellwig wrote: > > On Sun, Nov 03, 2002 at 11:46:48AM +0100, Geert Uytterhoeven wrote: > > > NCR53C9x ESP: C99 designated initializers > > > > Please move the host template to the C file instead of the header > > if you touch it. Having them in the header and the methods exported > > was needed in 2.2, but that's long ago.. > > At your service :-) > Except for the MIPS JAZZ driver, since SCSI_JAZZ_ESP is not actually used > anymore, probably due to bit rot. The patch looks fine, thanks. Now if all scsi host driver maintainers would do it this way.. :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/