Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbaBJC7t (ORCPT ); Sun, 9 Feb 2014 21:59:49 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:27070 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbaBJC7s (ORCPT ); Sun, 9 Feb 2014 21:59:48 -0500 Date: Sun, 9 Feb 2014 18:59:38 -0800 From: "Darrick J. Wong" To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" , linux-ext4@vger.kernel.org, josh@joshtriplett.org Subject: Re: [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Message-ID: <20140210025938.GD9176@birch.djwong.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 09, 2014 at 06:41:21PM +0530, Rashika Kheria wrote: > Mark functions as static in jbd2/journal.c because they are not used > outside this file. > > This eliminates the following warning in jbd2/journal.c: > fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes] > fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes] > fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Looks fine to me, so you can add Reviewed-by: Darrick J. Wong --D > --- > fs/jbd2/journal.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 5fa344a..244b6f6 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug); > #endif > > /* Checksumming functions */ > -int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb) > +static int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb) > { > if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2)) > return 1; > @@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t *j, journal_superblock_t *sb) > return cpu_to_be32(csum); > } > > -int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb) > +static int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb) > { > if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2)) > return 1; > @@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb) > return sb->s_checksum == jbd2_superblock_csum(j, sb); > } > > -void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb) > +static void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb) > { > if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2)) > return; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/