Message-ID: <1392012424.3178.23.camel@joe-AO722>
Subject: Re: [PATCH] staging : ion : Fix some checkpatch warnings and an
 error
From: Joe Perches <joe@perches.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, swetland@google.com, john.stultz@linaro.org,
        rebecca@android.com, ccross@android.com, ohaugan@codeaurora.org,
        romlem@google.com, linux-kernel@vger.kernel.org,
        devel <devel@driverdev.osuosl.org>
Date: Sun, 09 Feb 2014 22:07:04 -0800
In-Reply-To: <81912500.jvGoQpGOq5@daeseok-laptop.cloud.net>
References: <81912500.jvGoQpGOq5@daeseok-laptop.cloud.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-02-10 at 14:56 +0900, Daeseok Youn wrote:
>

Hello.

> diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
[]
> -	struct sg_table *(*map_dma) (struct ion_heap *heap,
> +	struct sg_table * (*map_dma)(struct ion_heap *heap,

The message about space required after "struct sg_table *"
is a checkpatch defect.  This is better as:

	struct sg_table *(*map_dma)(struct ion_heap *heap, etc...)

I'll fix checkpatch in a little bit.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/