Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbaBJIGY (ORCPT ); Mon, 10 Feb 2014 03:06:24 -0500 Received: from ch1ehsobe002.messaging.microsoft.com ([216.32.181.182]:49596 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbaBJIGU (ORCPT ); Mon, 10 Feb 2014 03:06:20 -0500 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -1 X-BigFish: VS-1(z551biz98dIe0eah1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6hzz1de098h8275bh1de097hz2dh2a8h839h944hd25hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1b2fh2222h224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h209eh2216h22d0h2336h2438h2461h2487h24d7h2516h2545h1155h) Date: Mon, 10 Feb 2014 15:50:32 +0800 From: Nicolin Chen To: Xiubo Li CC: , , , , , Subject: Re: [PATCH] ASoC: fsl-esai: fix ESAI TDM slot setting Message-ID: <20140210075031.GA16453@MrMyself> References: <1392014837-22308-1-git-send-email-Li.Xiubo@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1392014837-22308-1-git-send-email-Li.Xiubo@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-FOPE-CONNECTOR: Id%0$Dn%FREESCALE.MAIL.ONMICROSOFT.COM$RO%1$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 02:47:17PM +0800, Xiubo Li wrote: > Cc: Nicolin Chen > Signed-off-by: Xiubo Li > --- > sound/soc/fsl/fsl_esai.c | 4 ++-- > sound/soc/fsl/fsl_esai.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c > index d0c72ed..c84026c 100644 > --- a/sound/soc/fsl/fsl_esai.c > +++ b/sound/soc/fsl/fsl_esai.c > @@ -326,7 +326,7 @@ static int fsl_esai_set_dai_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask, > regmap_update_bits(esai_priv->regmap, REG_ESAI_TSMA, > ESAI_xSMA_xS_MASK, ESAI_xSMA_xS(tx_mask)); > regmap_update_bits(esai_priv->regmap, REG_ESAI_TSMB, > - ESAI_xSMA_xS_MASK, ESAI_xSMB_xS(tx_mask)); > + ESAI_xSMB_xS_MASK, ESAI_xSMB_xS(tx_mask)); > > regmap_update_bits(esai_priv->regmap, REG_ESAI_RCCR, > ESAI_xCCR_xDC_MASK, ESAI_xCCR_xDC(slots)); > @@ -334,7 +334,7 @@ static int fsl_esai_set_dai_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask, > regmap_update_bits(esai_priv->regmap, REG_ESAI_RSMA, > ESAI_xSMA_xS_MASK, ESAI_xSMA_xS(rx_mask)); > regmap_update_bits(esai_priv->regmap, REG_ESAI_RSMB, > - ESAI_xSMA_xS_MASK, ESAI_xSMB_xS(rx_mask)); > + ESAI_xSMB_xS_MASK, ESAI_xSMB_xS(rx_mask)); > > esai_priv->slot_width = slot_width; > > diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h > index 9c9f957..75e1403 100644 > --- a/sound/soc/fsl/fsl_esai.h > +++ b/sound/soc/fsl/fsl_esai.h > @@ -322,7 +322,7 @@ > #define ESAI_xSMB_xS_SHIFT 0 > #define ESAI_xSMB_xS_WIDTH 16 > #define ESAI_xSMB_xS_MASK (((1 << ESAI_xSMB_xS_WIDTH) - 1) << ESAI_xSMB_xS_SHIFT) > -#define ESAI_xSMB_xS(v) (((v) >> ESAI_xSMA_xS_WIDTH) & ESAI_xSMA_xS_MASK) > +#define ESAI_xSMB_xS(v) (((v) >> ESAI_xSMA_xS_WIDTH) & ESAI_xSMB_xS_MASK) It should use ESAI_xSMB_xS_WIDTH. Otherwise, it looks fine. Thank you. Acked-by: Nicolin Chen --- > > /* Port C Direction Register -- REG_ESAI_PRRC 0xF8 */ > #define ESAI_PRRC_PDC_SHIFT 0 > -- > 1.8.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/