Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbaBJIwm (ORCPT ); Mon, 10 Feb 2014 03:52:42 -0500 Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751108AbaBJIwi (ORCPT ); Mon, 10 Feb 2014 03:52:38 -0500 Message-ID: <52F89350.9090404@nod.at> Date: Mon, 10 Feb 2014 09:52:32 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Paul Bolle , David Howells , Koichi Yasutake , "moderated list:PANASONIC MN10300..." , open list Subject: Re: [PATCH 24/28] Remove DEPRECATED References: <1391971686-9517-1-git-send-email-richard@nod.at> <1391971686-9517-25-git-send-email-richard@nod.at> <1391974709.25855.3.camel@x220> <52F7DF51.8000507@nod.at> <1391976929.25855.22.camel@x220> <52F7E34E.3010509@nod.at> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 10.02.2014 09:49, schrieb Geert Uytterhoeven: > On Sun, Feb 9, 2014 at 9:21 PM, Richard Weinberger wrote: >> Am 09.02.2014 21:15, schrieb Paul Bolle: >>> On Sun, 2014-02-09 at 21:04 +0100, Richard Weinberger wrote: >>>> Am 09.02.2014 20:38, schrieb Paul Bolle: >>>>> But now you've enabled a lot of stuff that, as far as I can tell, could >>>>> not have been built since v2.6.39. >>>> >>>> This is by design. If the code does not build/work it needs to be fixed or removed. >>> >>> If that was the design goal of this patch (and similar patches you've >>> sent) it would have been proper to at least say a few words along those >>> lines in the commit explanation. >> >> I assumed that every kernel developer is aware of that fact that unreachable/dead code >> should be removed. > > Yes, it should be removed. > > But that's not what you did. You did the Kconfig-equivalent of removing a > "#if 0" in a C source file, which causes havoc. Fair point. I'll remove that code in v2. Hopefully I can catch all breakage on my testbed as many archs/configs are involved. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/