Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbaBJKOw (ORCPT ); Mon, 10 Feb 2014 05:14:52 -0500 Received: from mail-qc0-f174.google.com ([209.85.216.174]:35470 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbaBJKOr (ORCPT ); Mon, 10 Feb 2014 05:14:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <1391529538-21685-1-git-send-email-ulf.hansson@linaro.org> <1391529538-21685-15-git-send-email-ulf.hansson@linaro.org> Date: Mon, 10 Feb 2014 11:14:46 +0100 Message-ID: Subject: Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM From: Ulf Hansson To: Linus Walleij Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , Alessandro Rubini , Wolfram Sang , Chris Ball , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , linux-spi@vger.kernel.org, "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 February 2014 15:34, Linus Walleij wrote: > On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > >> Since the device is active while a successful probe has been completed, >> the reference counting for the clock will be screwed up and never reach >> zero. >> >> The issue is resolved by implementing runtime PM callbacks and let them >> handle the resources accordingly, including the clock. >> >> Cc: Alessandro Rubini >> Cc: Linus Walleij >> Cc: Wolfram Sang >> Signed-off-by: Ulf Hansson > > Hm do I read it right as patch 13 breaks runtime PM by leaving > the device active after probe() and this patch > 14 fixes it again? Maybe these two patches should be squashed > then. You are right; but the driver will still be working, you just don't get the benefit from inactivating the device at request inactivity - as you pointed out. The reason for why I wanted to do this as separate steps was to make it easier for reviewing, otherwise the patch(es) would have been quite big and messy. I am for sure open to adopt to your proposal, but just wanted to give you some more background, before I go ahead and send a v2. Kind regards Ulf Hansson > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/