Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbaBJLHk (ORCPT ); Mon, 10 Feb 2014 06:07:40 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:54201 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbaBJLHg (ORCPT ); Mon, 10 Feb 2014 06:07:36 -0500 Date: Mon, 10 Feb 2014 11:07:23 +0000 From: Mark Rutland To: Naveen Krishna Ch Cc: Naveen Krishna Chatradhi , "linux-pm@vger.kernel.org" , "rui.zhang@intel.com" , "eduardo.valentin@ti.com" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "amit.daniel@samsung.com" , "kgene.kim@samsung.com" , "devicetree@vger.kernel.org" , "b.zolnierkie@samsung.com" , "cpgs@samsung.com" Subject: Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register Message-ID: <20140210110723.GV25314@e106331-lin.cambridge.arm.com> References: <1383828154-428-1-git-send-email-ch.naveen@samsung.com> <20140210103354.GT25314@e106331-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Thread-Topic: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register Accept-Language: en-GB, en-US Content-Language: en-US acceptlanguage: en-GB, en-US User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 10:50:01AM +0000, Naveen Krishna Ch wrote: > Hello Mark, > > On 10 February 2014 16:03, Mark Rutland wrote: > > On Thu, Nov 07, 2013 at 12:42:34PM +0000, Naveen Krishna Chatradhi wrote: > >> On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from > >> the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second > >> should be acompanied by enabling the respective clock. > >> > >> This patch which allow for a "clk_sec" clock to be specified in the > >> device-tree which will be ungated when accessing the TRIMINFO register. > > > > Missing binding document update? Or was "clk_sec" originally in the > > binding but unused? > > > > The code seems to expect "tmu_apbif_sec" as the clock name in the DT, > > but this isn't mentioned in the commit message. > > > > I grepped Documentation/devicetree in mainline, but found no reference > > of either. > > > > Thanks, > > Mark. > This CL is to be abandoned. Ok. > > As mentioned in the previous replies to this patch. > The changes in this patched were merged with > http://www.spinics.net/lists/devicetree/msg15165.html > > The latest patch set can be found at. > 1. http://www.spinics.net/lists/devicetree/msg15163.html > 2. http://www.spinics.net/lists/devicetree/msg15164.html > 3. http://www.spinics.net/lists/devicetree/msg15165.html > 4. http://www.spinics.net/lists/devicetree/msg15165.html I responded here because of your ping message on 2014-02-07. The latest patches seem to have been posted before that. Was the ping misplaced or have I misunderstood? Thanks, Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/