Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbaBJLff (ORCPT ); Mon, 10 Feb 2014 06:35:35 -0500 Received: from kolab.o2s.ch ([77.109.136.180]:53092 "EHLO kolab.o2s.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaBJLfd (ORCPT ); Mon, 10 Feb 2014 06:35:33 -0500 From: David =?ISO-8859-1?Q?Lanzend=F6rfer?= To: Priit Laes Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, Ulf Hansson , Laurent Pinchart , Mike Turquette , Simon Baatz , Hans de Goede , Emilio =?ISO-8859-1?Q?L=F3pez?= , linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org, H Hartley Sweeten , Tejun Heo , Maxime Ripard , Guennadi Liakhovetski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 4/7] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs Date: Mon, 10 Feb 2014 12:35:13 +0100 Message-ID: <7779575.QASLIT4FqB@dizzy-6.o2s.ch> Organization: O2S GmbH User-Agent: KMail/4.11.5 (Linux/3.11.10-7-desktop; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <20140207212709.24624.58619.stgit@dizzy-6.o2s.ch> <20140207213316.24624.28705.stgit@dizzy-6.o2s.ch> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2134609.aEC1CZKHjS"; micalg="pgp-sha1"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart2134609.aEC1CZKHjS Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi > > + (cmd->opcode == 5 || cmd->opcode == 52)) > Aren't these the ones defined in linux/mmc/sdio.h: > 5 - SD_IO_SEND_OP_COND > 52 - SD_IO_RW_DIRECT Yes. They are... Changed that. Also I removed the camel cases and the defines within the struct definition. > > +struct sunxi_mmc_clk_dly { > > + u32 mode; > > + u32 oclk_dly; > > + u32 sclk_dly; > Do these members have to be u32? They all seem to be smaller than 10. Yes. Because of situations where it gets used in bit operations, and shorter types mess things up and prevent the driver from working ;-) cheer david --nextPart2134609.aEC1CZKHjS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlL4uXQACgkQAeZw77btGjovpgCgrjjxftD8MfEMous18vmmBe4v /AgAn2+dxNZXiX4DmmpIMEKaqVh0yEwi =AKAv -----END PGP SIGNATURE----- --nextPart2134609.aEC1CZKHjS-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/