Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbaBJM0u (ORCPT ); Mon, 10 Feb 2014 07:26:50 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:54621 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaBJM0o (ORCPT ); Mon, 10 Feb 2014 07:26:44 -0500 Date: Mon, 10 Feb 2014 13:26:40 +0100 From: Michal Hocko To: Frederic Weisbecker Cc: LKML , Andrew Morton , Christoph Hellwig , Don Zickus , Ingo Molnar , Jan Kara , Jens Axboe , "Srivatsa S. Bhat" Subject: Re: [PATCH 09/11] watchdog: Simplify a little the IPI call Message-ID: <20140210122640.GB7117@dhcp22.suse.cz> References: <1391876320-25068-1-git-send-email-fweisbec@gmail.com> <1391876320-25068-10-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391876320-25068-10-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 08-02-14 17:18:38, Frederic Weisbecker wrote: > In order to remotely restart the watchdog hrtimer, update_timers() > allocates a csd on the stack and pass it to __smp_call_function_single(). > > There is no partcular need, however, for a specific csd here. Lets > simplify that a little by calling smp_call_function_single() > which can already take care of the csd allocation by itself. > > Cc: Andrew Morton > Cc: Christoph Hellwig > Cc: Don Zickus > Cc: Ingo Molnar > Cc: Jan Kara > Cc: Jens Axboe > Cc: Michal Hocko > Cc: Srivatsa S. Bhat > Signed-off-by: Frederic Weisbecker Looks good to me. Reviewed-by: Michal Hocko > --- > kernel/watchdog.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 4431610..01c6f97 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -505,7 +505,6 @@ static void restart_watchdog_hrtimer(void *info) > > static void update_timers(int cpu) > { > - struct call_single_data data = {.func = restart_watchdog_hrtimer}; > /* > * Make sure that perf event counter will adopt to a new > * sampling period. Updating the sampling period directly would > @@ -515,7 +514,7 @@ static void update_timers(int cpu) > * might be late already so we have to restart the timer as well. > */ > watchdog_nmi_disable(cpu); > - __smp_call_function_single(cpu, &data, 1); > + smp_call_function_single(cpu, restart_watchdog_hrtimer, NULL, 1); > watchdog_nmi_enable(cpu); > } > > -- > 1.8.3.1 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/