Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbaBJMbT (ORCPT ); Mon, 10 Feb 2014 07:31:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaBJMbS (ORCPT ); Mon, 10 Feb 2014 07:31:18 -0500 Subject: Re: [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c From: Steven Whitehouse To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com, josh@joshtriplett.org In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Organization: Red Hat UK Ltd Date: Mon, 10 Feb 2014 12:30:20 +0000 Message-ID: <1392035420.2726.16.camel@menhir> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, 2014-02-09 at 18:40 +0530, Rashika Kheria wrote: > Mark functions as static in gfs2/rgrp.c because they are not used > outside this file. > > This eliminates the following warning in gfs2/rgrp.c: > fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ‘gfs2_rgrp_bh_get’ [-Wmissing-prototypes] > fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ‘update_rgrp_lvb’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett > --- > fs/gfs2/rgrp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Now in the GFS2 -nmw tree. Thanks, Steve. > diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c > index a1da213..551b9e9 100644 > --- a/fs/gfs2/rgrp.c > +++ b/fs/gfs2/rgrp.c > @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd) > * Returns: errno > */ > > -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd) > +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd) > { > struct gfs2_sbd *sdp = rgd->rd_sbd; > struct gfs2_glock *gl = rgd->rd_gl; > @@ -1169,7 +1169,7 @@ fail: > return error; > } > > -int update_rgrp_lvb(struct gfs2_rgrpd *rgd) > +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd) > { > u32 rl_flags; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/