Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752222AbaBJN6w (ORCPT ); Mon, 10 Feb 2014 08:58:52 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:59810 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751371AbaBJN6t (ORCPT ); Mon, 10 Feb 2014 08:58:49 -0500 Date: Mon, 10 Feb 2014 13:58:45 +0000 From: Russell King - ARM Linux To: Will Deacon Cc: Fabrice GASNIER , "u.kleine-koenig@pengutronix.de" , Jonathan Austin , Catalin Marinas , "nico@linaro.org" , "sboyd@codeaurora.org" , Marc Zyngier , "ben.dooks@codethink.co.uk" , "vgupta@synopsys.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "maxime.coquelin@st.com" Subject: Re: [RFC PATCH] ARM: Add imprecise abort enable/disable macro Message-ID: <20140210135845.GV26684@n2100.arm.linux.org.uk> References: <1391789955-26927-1-git-send-email-fabrice.gasnier@st.com> <1391789955-26927-2-git-send-email-fabrice.gasnier@st.com> <20140207170903.GT5976@mudshark.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140207170903.GT5976@mudshark.cambridge.arm.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 07, 2014 at 05:09:03PM +0000, Will Deacon wrote: > On Fri, Feb 07, 2014 at 04:19:15PM +0000, Fabrice GASNIER wrote: > > +#define local_abt_enable() \ > > + ({ \ > > + unsigned long temp; \ > > + __asm__ __volatile__( \ > > + "mrs %0, cpsr @ sta\n" \ > > +" bic %0, %0, %1\n" \ > > +" msr cpsr_c, %0" \ > > + : "=r" (temp) \ > > + : "r" (PSR_A_BIT) \ > > Can you use "i" instead of a register for this constant? As the PSR A bit isn't in bits 7-0, cpsr_c isn't what's required here. It needs something different... that's why my previous patch for you didn't work. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/