Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbaBJP4f (ORCPT ); Mon, 10 Feb 2014 10:56:35 -0500 Received: from mail-we0-f182.google.com ([74.125.82.182]:55315 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752799AbaBJP4d (ORCPT ); Mon, 10 Feb 2014 10:56:33 -0500 Date: Mon, 10 Feb 2014 15:56:28 +0000 From: Lee Jones To: Sachin Kamat Cc: Laszlo Papp , Linus Walleij , LKML Subject: Re: [PATCH v2] mfd: MAX6650/6651 support Message-ID: <20140210155628.GA26997@lee--X1> References: <1391859219-3102-1-git-send-email-lpapp@kde.org> <20140210122129.GA23053@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > >> Please arrange these alphabetically. > > > > Why? > > 1. It makes it easier to avoid adding duplicate includes. > 2. Code looks more ordered/organized. > 3. Prevents further clean up patches arranging them so :) I wouldn't accept any patches doing such worthless things. ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/