Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222AbaBJUFl (ORCPT ); Mon, 10 Feb 2014 15:05:41 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:39292 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753768AbaBJUFf (ORCPT ); Mon, 10 Feb 2014 15:05:35 -0500 MIME-Version: 1.0 In-Reply-To: References: <1391802529-29861-1-git-send-email-marek@goldelico.com> <1392020862.4128.1.camel@jlt4.sipsolutions.net> Date: Mon, 10 Feb 2014 21:05:31 +0100 Message-ID: Subject: Re: [PATCH] net: rfkill-regulator: Add devicetree support. From: Belisko Marek To: "Dr. H. Nikolaus Schaller" Cc: Johannes Berg , Rob Herring , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Rob Landley , "John W. Linville" , David Miller , Grant Likely , NeilBrown Brown , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , LKML , linux-wireless@vger.kernel.org, netdev Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 9:54 AM, Dr. H. Nikolaus Schaller wrote: > Am 10.02.2014 um 09:27 schrieb Johannes Berg: > >> On Fri, 2014-02-07 at 20:48 +0100, Marek Belisko wrote: >> >>> +#define RFKILL_TYPE_ALL (0) >>> +#define RFKILL_TYPE_WLAN (1) >>> +#define RFKILL_TYPE_BLUETOOTH (2) >>> +#define RFKILL_TYPE_UWB (3) >>> +#define RFKILL_TYPE_WIMAX (4) >>> +#define RFKILL_TYPE_WWAN (5) >>> +#define RFKILL_TYPE_GPS (6) >>> +#define RFKILL_TYPE_FM (7) >>> +#define RFKILL_TYPE_NFC (8) >> >> This seems like a bad idea since there's an enum elsewhere in userspace >> API already. I know this is duplicate but in device tree we cannot use enums (AFAIU include/dt-bindings are defines used in device tree files) > > Yes, > you are right. It is defined in include/uapi/linux/rfkill.h > > Tnx, > Nikolaus > BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/