Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 3 Nov 2002 15:55:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 3 Nov 2002 15:55:15 -0500 Received: from astound-64-85-224-253.ca.astound.net ([64.85.224.253]:13835 "EHLO master.linux-ide.org") by vger.kernel.org with ESMTP id ; Sun, 3 Nov 2002 15:55:13 -0500 Date: Sun, 3 Nov 2002 13:00:15 -0800 (PST) From: Andre Hedrick To: Erik Andersen cc: bert hubert , linux-kernel@vger.kernel.org Subject: Re: [PATCH] de-cryptify ide-disk host protected area output In-Reply-To: <20021026132419.GA11930@codepoet.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 38 Agreed w/ Erik. On Sat, 26 Oct 2002, Erik Andersen wrote: > On Sat Oct 26, 2002 at 03:07:01PM +0200, bert hubert wrote: > > Useless number '1' being printed leading to operator confusion. > > > > --- linux-2.5.44/drivers/ide/ide-disk.c~orig Sat Oct 26 14:59:35 2002 > > +++ linux-2.5.44/drivers/ide/ide-disk.c Sat Oct 26 15:00:40 2002 > > @@ -1128,7 +1128,7 @@ > > { > > int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0; > > if (flag) > > - printk("%s: host protected area => %d\n", drive->name, flag); > > + printk("%s: supports host protected area", drive->name); > > return flag; > > } > > Even better -- kill the prink entirely. If anyone really > cares, they can run 'hdparm -I ' and get the > exhaustive list of everything the drive supports.... > > -Erik > > -- > Erik B. Andersen http://codepoet-consulting.com/ > --This message was written using 73% post-consumer electrons-- > Andre Hedrick LAD Storage Consulting Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/