Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbaBKIDe (ORCPT ); Tue, 11 Feb 2014 03:03:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34830 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbaBKIDa (ORCPT ); Tue, 11 Feb 2014 03:03:30 -0500 Date: Tue, 11 Feb 2014 00:03:30 -0800 From: Andrew Morton To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Jason Low , Waiman Long , mingo@kernel.org, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, tglx@linutronix.de, riel@redhat.com, davidlohr@hp.com, hpa@zytor.com, andi@firstfloor.org, aswin@hp.com, scott.norton@hp.com, chegu_vinod@hp.com Subject: Re: [PATCH 0/8] locking/core patches Message-Id: <20140211000330.d791513d.akpm@linux-foundation.org> In-Reply-To: <20140211071700.GH27965@twins.programming.kicks-ass.net> References: <20140210195820.834693028@infradead.org> <20140210150230.b7f46688093ebc5c45fee870@linux-foundation.org> <20140211071700.GH27965@twins.programming.kicks-ass.net> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Feb 2014 08:17:00 +0100 Peter Zijlstra wrote: > On Mon, Feb 10, 2014 at 03:02:30PM -0800, Andrew Morton wrote: > > On Mon, 10 Feb 2014 20:58:20 +0100 Peter Zijlstra wrote: > > > > > Hi all, > > > > > > I would propose merging the following patches... > > > > > > The first set is mostly from Jason and tweaks the mutex adaptive > > > spinning, AIM7 throughput numbers: > > > > > Jobs/min/ Jobs/sec/ Time: Time: Time: Time: Running child time > Forks Jobs/min child child parent childU childS std_dev JTI :max :min > > > > PRE: 100 2000.04 21564.90 2721.29 311.99 3.12 0.01 0.00 99 > > > POST: 100 2000.04 42603.85 5142.80 311.99 3.12 0.00 0.00 99 > > > > What do these columns represent? I'm guessing the large improvement > > was in context switches? > > I pasted the header from reaim above; hmpf. I wonder what's the difference between Jobs/min, Jobs/min(child) and Jobs/sec(child), which is not Jobs/min(child) / 60. > I'm not entirely sure what the > bloody thing does and I hate that it takes hours to get these numbers :/ > > Bloody stupid benchmark if you ask me. heh, yes, it's stupid how long many benchmarks take. Ditch it. A change like this should be testable with a 30-line microbenchmark which runs in 5 seconds tops. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/