Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751589AbaBKKKV (ORCPT ); Tue, 11 Feb 2014 05:10:21 -0500 Received: from mail-pb0-f53.google.com ([209.85.160.53]:48370 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbaBKKKS (ORCPT ); Tue, 11 Feb 2014 05:10:18 -0500 MIME-Version: 1.0 In-Reply-To: References: <1391859219-3102-1-git-send-email-lpapp@kde.org> Date: Tue, 11 Feb 2014 10:10:17 +0000 X-Google-Sender-Auth: HsEYsb7UK_-9iCbigdYcKuk93cY Message-ID: Subject: Re: [PATCH v2] mfd: MAX6650/6651 support From: Laszlo Papp To: Sachin Kamat Cc: LKML , Lee Jones Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> [snip] >>>> + >>>> +struct max665x_dev { >>>> + struct device *dev; >>>> + struct mutex iolock; >>>> + >>>> + struct i2c_client *i2c; >>>> + struct regmap *map; >>>> + >>>> + int type; >>> >>> Unnecessary extra lines above could be removed. >> >> I prefer it that way, but I will remove the two extra lines as you wish. > > As I already said, these are just nits and only since you were > re-spinning the patch, > I suggested them. Also, since this is a new file being added, it > avoids further patches > doing these same things. Well, it is worse in my opinion because it makes the code more bloated without separation between units, but I made the requested change anyway because the feature matters lotta more to me than this styling. Hope it is OK now? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/