Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbaBKKWZ (ORCPT ); Tue, 11 Feb 2014 05:22:25 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:65365 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbaBKKWW (ORCPT ); Tue, 11 Feb 2014 05:22:22 -0500 MIME-Version: 1.0 In-Reply-To: <20140211085053.GD32042@lee--X1> References: <1392045953-26596-1-git-send-email-lpapp@kde.org> <20140210160842.GB26997@lee--X1> <20140210173811.04ba5964@endymion.delvare> <20140211085014.4ef32b56@endymion.delvare> <20140211085053.GD32042@lee--X1> Date: Tue, 11 Feb 2014 10:22:22 +0000 X-Google-Sender-Auth: 446e-S84I2doCyE5ytQ3lLk5WWs Message-ID: Subject: Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix From: Laszlo Papp To: Lee Jones Cc: Jean Delvare , LKML , lm-sensors@lm-sensors.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote: >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote: >> >> > Additionally, dashes are explicitly forbidden in hwmon >> >> > device names. >> >> >> >> Also, where is that documented? >> > >> > In Documentation/hwmon/sysfs-interface: >> > >> > ********************* >> > * Global attributes * >> > ********************* >> > >> > name The chip name. >> > This should be a short, lowercase string, not containing >> > spaces nor dashes, representing the chip name. This is >> > the only mandatory attribute. >> > I2C devices get this attribute created automatically. >> > RO >> >> Time to revisit this decision.... >> >> So, based on the fact that children device names usually contain >> dashes, I do not understand why hwmon would be any special in this >> regard. It is possible that the hwmon developers have not faced much >> MFD situation before, and so, this was not considered to be handled >> like in other subsystems. >> >> I am proposing to change this "rule"... Any objection? > > Prior to proposing such an invasive change which is highly likely to > come up against heavy opposition, why don't you try to work _with_ the > current ruling and the Maintainers to see what others have done to > solve the problem. I highly doubt you are the first/only developer who > has had this issue. > > Do: > `git grep "\-hwmon"` > > ... and have a good look around for an accepted solution. Well, this did not bring up relevant results, at least for my understanding, but I will send a new patch with the devm_hwmon_device_register_ with_groups() stuff based on my little understanding without further help. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/