Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752708AbaBKMXq (ORCPT ); Tue, 11 Feb 2014 07:23:46 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:54033 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbaBKMXm (ORCPT ); Tue, 11 Feb 2014 07:23:42 -0500 MIME-Version: 1.0 In-Reply-To: References: <1391859219-3102-1-git-send-email-lpapp@kde.org> Date: Tue, 11 Feb 2014 12:23:41 +0000 X-Google-Sender-Auth: iI4PQPli1o7y-CY5gAT09jLEORQ Message-ID: Subject: Re: [PATCH v2] mfd: MAX6650/6651 support From: Laszlo Papp To: Sachin Kamat Cc: LKML , Lee Jones Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2014 at 11:42 AM, Sachin Kamat wrote: > On 11 February 2014 17:09, Laszlo Papp wrote: >> On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat wrote: >>> On 11 February 2014 15:40, Laszlo Papp wrote: >>>>>>> [snip] >>>>>>>> + >>>>>>>> +struct max665x_dev { >>>>>>>> + struct device *dev; >>>>>>>> + struct mutex iolock; >>>>>>>> + >>>>>>>> + struct i2c_client *i2c; >>>>>>>> + struct regmap *map; >>>>>>>> + >>>>>>>> + int type; >>>>>>> >>>>>>> Unnecessary extra lines above could be removed. >>>>>> >>>>>> I prefer it that way, but I will remove the two extra lines as you wish. >>>>> >>>>> As I already said, these are just nits and only since you were >>>>> re-spinning the patch, >>>>> I suggested them. Also, since this is a new file being added, it >>>>> avoids further patches >>>>> doing these same things. >>>> >>>> Well, it is worse in my opinion because it makes the code more bloated >>>> without separation between units, but I made the requested change >>>> anyway because the feature matters lotta more to me than this styling. >>>> Hope it is OK now? >>> >>> The only thing that you missed among what you agreed to change is the >>> arrangement of >>> "depends on" and "select" in Kconfig. Rest look OK. Thanks for taking care. >> >> Ah, true. I will do that tomorrow if it is a blocker for the integration. > > I don't think it is a blocker in any way and you may choose to ignore > it as well. That is alright, Sachin. I will make this change from home. Perhaps, it is wise anyhow to wait for more feedback, like e.g. from Lee, etc. Thanks again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/