Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbaBKQ1w (ORCPT ); Tue, 11 Feb 2014 11:27:52 -0500 Received: from mail-ee0-f53.google.com ([74.125.83.53]:34798 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbaBKQ1u (ORCPT ); Tue, 11 Feb 2014 11:27:50 -0500 Date: Tue, 11 Feb 2014 16:27:43 +0000 From: Lee Jones To: "Anthony Olech " Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, David Dajun Chen Subject: Re: [PATCH V2] mfd: da9052: Fix volatile register definition ommissions Message-ID: <20140211162743.GC15081@lee--X1> References: <201402111611.s1BGBXkr056672@swsrvapps-02.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201402111611.s1BGBXkr056672@swsrvapps-02.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Feb 2014, Anthony Olech wrote: > Three of the PMIC registers have some bits that are changed > autonomously by the PMIC itself (some time) after being set > by some component driver of the DA9052 PMIC and hence they > need to be marked as volatile so that the regmap API will > not cache their values. > > Signed-off-by: Anthony Olech > Acked-by: David Dajun Chen > --- > > This patch is relative to linux-next repository tag next-20140206 > > The problem was detected whilst running a scripted set of functional > regression tests whilst investigating a different problem. > > This patch has been test compiled on an amd64 server for both x86 > and arm targets. > > This patch has been spot verified using an SMDK6410 platform > fly-wired to a Dialog da9053 EVB. > > The bug that this patch fixes affects two components of DA9052 namely: > > WATCHDOG - the first kick will work but sebsequent ones will not > thus the watchdog will timeout at 2 x interval. > > REGULATORS - the first change to any DA9052/DA9053 BUCK voltage > will be actioned, but sebsequent ones will not. > > drivers/mfd/da9052-core.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/