Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbaBKRw1 (ORCPT ); Tue, 11 Feb 2014 12:52:27 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:52582 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbaBKRw0 (ORCPT ); Tue, 11 Feb 2014 12:52:26 -0500 X-IronPort-AV: E=Sophos;i="4.95,826,1384300800"; d="scan'208";a="99873184" Message-ID: <52FA6352.1010403@citrix.com> Date: Tue, 11 Feb 2014 17:52:18 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20121215 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= CC: Sander Eikelenboom , Konrad Rzeszutek Wilk , Jens Axboe , , , , , , Subject: Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation. References: <20140210184412.GA18198@phenom.dumpdata.com> <20140210195402.GA3924@kernel.dk> <771950784.20140211165215@eikelenboom.it> <20140211155650.GA23026@phenom.dumpdata.com> <1542261541.20140211170750@eikelenboom.it> <52FA6072.40908@citrix.com> In-Reply-To: <52FA6072.40908@citrix.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.2.76] X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/14 17:40, Roger Pau Monn? wrote: > On 11/02/14 17:07, Sander Eikelenboom wrote: >> >> Tuesday, February 11, 2014, 4:56:50 PM, you wrote: >> >>> On Tue, Feb 11, 2014 at 04:52:15PM +0100, Sander Eikelenboom wrote: >>>> Hi Konrad, >>>> >>>> Today decided to tryout another kernel RC and your pull request to Jens on top of it .. and I encoutered this one: >> >>> Thank you for testing! >> >>> Could you provide the .config file please? >> >> Attached >> >>> Did you see this _before_ the pull request with Jens? I presume >>> not, but just double checking? >> >> Nope not too my knowledge (though it's a bit messy with things broken on 3.14 at the moment) >> >>> And lastly - what were you doing when you triggered this? Just launching >>> a guest? >> >> Nope it triggers on guest shutdown .. >> >> >>> CC-ing Roger and other folks who were on the patches. >> >>>> >>>> >>>> [ 438.029756] INFO: trying to register non-static key. >>>> [ 438.029759] the code is fine but needs lockdep annotation. >>>> [ 438.029760] turning off the locking correctness validator. >>>> [ 438.029770] CPU: 3 PID: 9593 Comm: blkback.2.xvda Tainted: G W 3.14.0-rc2-20140211-pcireset-net-btrevert-xenblock+ #1 >>>> [ 438.029773] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 >>>> [ 438.029784] ffff88005224c4f0 ffff88004e5d9b68 ffffffff81b808c4 ffff88004ba2b510 >>>> [ 438.029791] 0000000000000002 ffff88004e5d9c38 ffffffff81116eab ffff88004e5d9bf8 >>>> [ 438.029798] ffffffff81117b35 0000000000000000 0000000000000000 ffffffff82cee570 >>>> [ 438.029799] Call Trace: >>>> [ 438.029815] [] dump_stack+0x46/0x58 >>>> [ 438.029826] [] __lock_acquire+0x1c2b/0x2220 >>>> [ 438.029833] [] ? lock_acquire+0xe5/0x150 >>>> [ 438.029841] [] lock_acquire+0xbd/0x150 >>>> [ 438.029847] [] ? flush_work+0x5/0x290 >>>> [ 438.029852] [] flush_work+0x3d/0x290 >>>> [ 438.029856] [] ? flush_work+0x5/0x290 >>>> [ 438.029863] [] ? lock_acquire+0xe5/0x150 >>>> [ 438.029872] [] ? xen_blkif_schedule+0x1a1/0x8d0 >>>> [ 438.029881] [] ? _raw_spin_unlock_irqrestore+0x6d/0x90 >>>> [ 438.029888] [] ? trace_hardirqs_on_caller+0xfb/0x240 >>>> [ 438.029894] [] ? trace_hardirqs_on+0xd/0x10 >>>> [ 438.029901] [] xen_blkif_schedule+0x289/0x8d0 >>>> [ 438.029907] [] ? __init_waitqueue_head+0x60/0x60 >>>> [ 438.029913] [] ? trace_hardirqs_on+0xd/0x10 >>>> [ 438.029919] [] ? _raw_spin_unlock_irqrestore+0x81/0x90 >>>> [ 438.029925] [] ? xen_blkif_be_int+0x40/0x40 >>>> [ 438.029932] [] kthread+0xe4/0x100 >>>> [ 438.029938] [] ? _raw_spin_unlock_irq+0x30/0x50 >>>> [ 438.029946] [] ? __init_kthread_worker+0x70/0x70 >>>> [ 438.029951] [] ret_from_fork+0x7c/0xb0 >>>> [ 438.029958] [] ? __init_kthread_worker+0x70/0x70 >>>> >>>> Doesn't seem to serious .. but never the less :-) > > Thanks for the report! > > Does the following patch solve the problem? > > --- > commit c1460953d081c8a18ac9e84fe90f696cdceae105 > Author: Roger Pau Monne > Date: Tue Feb 11 17:21:19 2014 +0100 > > xen-blkback: init persistent_purge_work work_struct > > Do a dummy initialization of the persistent_purge_work > work_struct on xen_blkif_alloc, so that when flush_work is called on > shutdown the struct is initialized even if it hasn't been used. > > Signed-off-by: Roger Pau Monn? > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index 84973c6..3df7575 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -129,6 +129,17 @@ static struct xen_blkif *xen_blkif_alloc(domid_t domid) > blkif->free_pages_num = 0; > atomic_set(&blkif->persistent_gnt_in_use, 0); > atomic_set(&blkif->inflight, 0); > + /* > + * Init the work struct with a NULL function, this is done > + * so that flush_work doesn't complain when shutting down if > + * persistent_purge_work has not been used during the lifetime > + * of this blkback instance. > + * > + * NB: In purge_persistent_gnt we make sure that > + * persistent_purge_work is always correctly setup with a valid > + * function pointer before being scheduled. > + */ > + INIT_WORK(&blkif->persistent_purge_work, NULL); I think you should init this fully here and remove the other call to INIT_WORK. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/