Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755631AbaBKUtH (ORCPT ); Tue, 11 Feb 2014 15:49:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54475 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754111AbaBKUtD (ORCPT ); Tue, 11 Feb 2014 15:49:03 -0500 Date: Tue, 11 Feb 2014 21:49:01 +0100 From: Jan Kara To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, josh@joshtriplett.org Subject: Re: [PATCH 08/21] fs: Mark function as static in ext3/dir.c Message-ID: <20140211204901.GD22835@quack.suse.cz> References: <999693f220bb65e2a07c4450548d99ea3ceac9d2.1391949868.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <999693f220bb65e2a07c4450548d99ea3ceac9d2.1391949868.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 09-02-14 18:36:27, Rashika Kheria wrote: > Mark function as static in ext3/dir.c because it is not used outside > this file. > > This also eliminates the following warning in ext3/dir.c: > fs/ext3/dir.c:278:8: warning: no previous prototype for ‘ext3_dir_llseek’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Thanks. I've merged the patch. Honza > --- > fs/ext3/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c > index e66e480..17742ee 100644 > --- a/fs/ext3/dir.c > +++ b/fs/ext3/dir.c > @@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp) > * NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX) > * will be invalid once the directory was converted into a dx directory > */ > -loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) > +static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) > { > struct inode *inode = file->f_mapping->host; > int dx_dir = is_dx_dir(inode); > -- > 1.7.9.5 > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/