Message-ID: <52FA99CA.8070505@kernel.dk>
Date: Tue, 11 Feb 2014 14:44:42 -0700
From: Jens Axboe <axboe@kernel.dk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Sander Eikelenboom <linux@eikelenboom.it>,
        David Vrabel <david.vrabel@citrix.com>
CC: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
        mrushton@amazon.com, msw@amazon.com, boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying
 to register non-static key. the code is fine but needs lockdep annotation.
References: <20140210184412.GA18198@phenom.dumpdata.com> <20140210195402.GA3924@kernel.dk> <771950784.20140211165215@eikelenboom.it> <20140211155650.GA23026@phenom.dumpdata.com> <1542261541.20140211170750@eikelenboom.it> <52FA6072.40908@citrix.com> <52FA6352.1010403@citrix.com> <52FA68AE.6070608@citrix.com> <52FA6A44.6050003@citrix.com> <1009282985.20140211212157@eikelenboom.it>
In-Reply-To: <1009282985.20140211212157@eikelenboom.it>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

On 2014-02-11 13:21, Sander Eikelenboom wrote:
>
> Tuesday, February 11, 2014, 7:21:56 PM, you wrote:
>
>> On 11/02/14 18:15, Roger Pau Monn? wrote:
>>> On 11/02/14 18:52, David Vrabel wrote:
>>>>
>>> That would mean that unmap_purged_grants would no longer be static and
>>> I should also add a prototype for it in blkback/common.h, which is kind
>>> of ugly IMHO.
>
>> But less ugly than initializing work with a NULL function, IMO.
>
>>> commit 980e72e45454b64ccb7f23b6794a769384e51038
>>> Author: Roger Pau Monne <roger.pau@citrix.com>
>>> Date:   Tue Feb 11 19:04:06 2014 +0100
>>>
>>>      xen-blkback: init persistent_purge_work work_struct
>>>
>>>      Initialize persistent_purge_work work_struct on xen_blkif_alloc (and
>>>      remove the previous initialization done in purge_persistent_gnt). This
>>>      prevents flush_work from complaining even if purge_persistent_gnt has
>>>      not been used.
>>>
>>>      Signed-off-by: Roger Pau Monn? <roger.pau@citrix.com>
>
>> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
>
> And a Tested-by: Sander Eikelenboom <linux@eikelenboom.it>

Konrad, I was going to ship my current tree today, but looks like we 
need this too.

-- 
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/