Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbaBLCX0 (ORCPT ); Tue, 11 Feb 2014 21:23:26 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:59083 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbaBLCXZ (ORCPT ); Tue, 11 Feb 2014 21:23:25 -0500 Date: Tue, 11 Feb 2014 18:23:22 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Paul Gortmaker cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , x86@kernel.org Subject: Re: [PATCH] x86: fix two sparse warnings in early boot string handling In-Reply-To: <20140212020010.GB21033@windriver.com> Message-ID: References: <1392143619-11453-1-git-send-email-paul.gortmaker@windriver.com> <20140212020010.GB21033@windriver.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Feb 2014, Paul Gortmaker wrote: > > > Fixes: > > > > > > arch/x86/boot/compressed/../string.c:60:14: warning: symbol 'atou' was not declared. Should it be static? > > > arch/x86/boot/string.c:133:6: warning: symbol 'strstr' was not declared. Should it be static? > > > > > > The atou one could be considered a false positive; it seems somehow > > > caused by including ./string.c from within /compressed/string.c file. > > > However git grep shows only the atou prototype and declaration, so > > > it is completely unused and we can hence delete it. > > > > > > > Declaring a prototype in a header file would be pointless if there is no > > current breakage; I don't see why you can't remove strstr() in > > arch/x86/boot/string.c entirely. What breaks? > > Explicit breakage vs. sparse warnings are two different things. It may > be that we can delete strstr() just like I did for atou() -- but in the > interest of doing the minimal change, I did just what was needed for > fixing the sparse warnings for strstr. I can test if it can be removed, > but it has the smell of generic-libc usage all over it... > When the minimal change is to add an unnecessary prototype for a function that is not referenced, it doesn't seem acceptable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/