Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752402AbaBLDPw (ORCPT ); Tue, 11 Feb 2014 22:15:52 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:29973 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbaBLDPu convert rfc822-to-8bit (ORCPT ); Tue, 11 Feb 2014 22:15:50 -0500 User-Agent: K-9 Mail for Android In-Reply-To: <52FA99CA.8070505@kernel.dk> References: <20140210184412.GA18198@phenom.dumpdata.com> <20140210195402.GA3924@kernel.dk> <771950784.20140211165215@eikelenboom.it> <20140211155650.GA23026@phenom.dumpdata.com> <1542261541.20140211170750@eikelenboom.it> <52FA6072.40908@citrix.com> <52FA6352.1010403@citrix.com> <52FA68AE.6070608@citrix.com> <52FA6A44.6050003@citrix.com> <1009282985.20140211212157@eikelenboom.it> <52FA99CA.8070505@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Subject: Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation. From: Konrad Rzeszutek Wilk Date: Tue, 11 Feb 2014 22:14:15 -0500 To: Jens Axboe , Sander Eikelenboom , David Vrabel CC: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, mrushton@amazon.com, msw@amazon.com, boris.ostrovsky@oracle.com Message-ID: <92e1a6a9-1993-4203-b38c-9c8da96a3ce7@email.android.com> X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On February 11, 2014 4:44:42 PM EST, Jens Axboe wrote: >On 2014-02-11 13:21, Sander Eikelenboom wrote: >> >> Tuesday, February 11, 2014, 7:21:56 PM, you wrote: >> >>> On 11/02/14 18:15, Roger Pau Monné wrote: >>>> On 11/02/14 18:52, David Vrabel wrote: >>>>> >>>> That would mean that unmap_purged_grants would no longer be static >and >>>> I should also add a prototype for it in blkback/common.h, which is >kind >>>> of ugly IMHO. >> >>> But less ugly than initializing work with a NULL function, IMO. >> >>>> commit 980e72e45454b64ccb7f23b6794a769384e51038 >>>> Author: Roger Pau Monne >>>> Date: Tue Feb 11 19:04:06 2014 +0100 >>>> >>>> xen-blkback: init persistent_purge_work work_struct >>>> >>>> Initialize persistent_purge_work work_struct on >xen_blkif_alloc (and >>>> remove the previous initialization done in >purge_persistent_gnt). This >>>> prevents flush_work from complaining even if >purge_persistent_gnt has >>>> not been used. >>>> >>>> Signed-off-by: Roger Pau Monné >> >>> Reviewed-by: David Vrabel >> >> And a Tested-by: Sander Eikelenboom > >Konrad, I was going to ship my current tree today, but looks like we >need this too. Yes. Are you OK taking it from this thread or would you like me to prep a GIT pull with it? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/