Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbaBLElV (ORCPT ); Tue, 11 Feb 2014 23:41:21 -0500 Received: from mail-oa0-f47.google.com ([209.85.219.47]:60283 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbaBLElT (ORCPT ); Tue, 11 Feb 2014 23:41:19 -0500 MIME-Version: 1.0 In-Reply-To: <1392143632-15405-1-git-send-email-robherring2@gmail.com> References: <1392143632-15405-1-git-send-email-robherring2@gmail.com> Date: Wed, 12 Feb 2014 10:11:19 +0530 Message-ID: Subject: Re: [PATCH v2] cpufreq: cpu0: drop selecting of THERMAL and THERMAL_CPU From: Viresh Kumar To: Rob Herring Cc: Linux Kernel Mailing List , Olof Johansson , Rob Herring , "Rafael J. Wysocki" , "cpufreq@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12 February 2014 00:03, Rob Herring wrote: > From: Rob Herring > > The addition of THERMAL and THERMAL_CPU selections causes a kconfig > warning on highbank platforms: > > warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has > unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && > REGULATOR && OF && THERMAL && CPU_THERMAL) > > The cpufreq-cpu0 driver does not require thermal zone support to > function as highbank does not need these, so drop selecting of THERMAL > and CPU_THERMAL. > > Reported-by: Olof Johansson > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: cpufreq@vger.kernel.org > Signed-off-by: Rob Herring > --- > v2: > - just drop selecting THERMAL and THERMAL_CPU instead of a new kconfig > option > > Dropping REGULATOR doesn't build w/o some empty regulator functions, so > that's 3.15 material. > > Rob > > drivers/cpufreq/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 4b029c0..d100926 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE > > config GENERIC_CPUFREQ_CPU0 > tristate "Generic CPU0 cpufreq driver" > - depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL > + depends on HAVE_CLK && REGULATOR && OF > select PM_OPP > help > This adds a generic cpufreq driver for CPU0 frequency management. Acked-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/