Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbaBLKje (ORCPT ); Wed, 12 Feb 2014 05:39:34 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:53967 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbaBLKjb (ORCPT ); Wed, 12 Feb 2014 05:39:31 -0500 MIME-Version: 1.0 In-Reply-To: <1392055139-19631-11-git-send-email-benjamin.tissoires@redhat.com> References: <1392055139-19631-1-git-send-email-benjamin.tissoires@redhat.com> <1392055139-19631-11-git-send-email-benjamin.tissoires@redhat.com> Date: Wed, 12 Feb 2014 11:39:31 +0100 Message-ID: Subject: Re: [PATCH 10/14] HID: wiimote: replace hid_output_raw_report with hid_hw_output_report for output requests From: David Herrmann To: Benjamin Tissoires Cc: Benjamin Tissoires , Jiri Kosina , "open list:HID CORE LAYER" , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > For BT transport layer, > ret = hid_output_raw_report(A, B, C, HID_OUTPUT_REPORT); > is equivalent to > ret = hid_hw_output_report(A, B, C); > > So use the new API where available Reviewed-by: David Herrmann Thanks David > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-wiimote-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c > index d7dc6c5b..d003914 100644 > --- a/drivers/hid/hid-wiimote-core.c > +++ b/drivers/hid/hid-wiimote-core.c > @@ -28,14 +28,14 @@ static int wiimote_hid_send(struct hid_device *hdev, __u8 *buffer, > __u8 *buf; > int ret; > > - if (!hdev->hid_output_raw_report) > + if (!hdev->ll_driver->output_report) > return -ENODEV; > > buf = kmemdup(buffer, count, GFP_KERNEL); > if (!buf) > return -ENOMEM; > > - ret = hid_output_raw_report(hdev, buf, count, HID_OUTPUT_REPORT); > + ret = hid_hw_output_report(hdev, buf, count); > > kfree(buf); > return ret; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/