Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbaBLVuE (ORCPT ); Wed, 12 Feb 2014 16:50:04 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:43269 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbaBLVuB (ORCPT ); Wed, 12 Feb 2014 16:50:01 -0500 Date: Wed, 12 Feb 2014 13:49:56 -0800 From: Guenter Roeck To: Andrew Chew Cc: Stephen Warren , "wim@iguana.be" , "rob@landley.net" , "thierry.reding@gmail.com" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , "abrestic@chromium.org" , "dgreid@chromium.org" , "katierh@chromium.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v5 1/1] watchdog: Add tegra watchdog Message-ID: <20140212214956.GA30463@roeck-us.net> References: <1391738086-29142-1-git-send-email-achew@nvidia.com> <52FBC2EF.4020000@wwwdotorg.org> <643E69AA4436674C8F39DCC2C05F76386319AB3891@HQMAIL03.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <643E69AA4436674C8F39DCC2C05F76386319AB3891@HQMAIL03.nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2014 at 01:43:37PM -0800, Andrew Chew wrote: > > > +static void tegra_wdt_unref(struct watchdog_device *wdd) { > > > + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); > > > + > > > + kref_put(&wdt->kref, tegra_wdt_release_resources); } > > > > I forget why these were needed; they seem to do nothing. > > The reason I did the whole kref thing was by following the guidance > in Documentation/watchdog/watchdog-kernel-api.txt, which says > that if the watchdog_device struct is dynamically allocated, then > one needs this. > I read that too, but I could not follow the logic behind it, nor the explanation provided with the commit introducing it ;-) Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/