Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbaBLWWs (ORCPT ); Wed, 12 Feb 2014 17:22:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbaBLWWq convert rfc822-to-8bit (ORCPT ); Wed, 12 Feb 2014 17:22:46 -0500 Date: Wed, 12 Feb 2014 17:22:41 -0500 From: Mike Snitzer To: Akhil Bhansali Cc: Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: skd: disable discard support Message-ID: <20140212222240.GC4265@redhat.com> References: <20140212221835.GA4265@redhat.com> <20140212221940.GB4265@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20140212221940.GB4265@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12 2014 at 5:19pm -0500, Mike Snitzer wrote: > On Wed, Feb 12 2014 at 5:18pm -0500, > Mike Snitzer wrote: > > > The skd driver has never handled discards reliably. > > > > The kernel will BUG as a result of issuing discards to the skd device. > > Disable the skd driver's discard support until it is proven reliable. > > Here is the first BUG I recently saw: And a 2nd: Kernel panic - not syncing: Watchdog detected hard LOCKUP on cpu 10 CPU: 10 PID: 0 Comm: swapper/10 Tainted: G W O 3.14.0-rc1.snitm+ #4 Hardware name: FUJITSU PRIMERGY RX300 S6 /D2619, BIOS 6.00 Rev. 1.10.2619.N1 05/24/2011 0000000000000000 ffff88033fd47bb8 ffffffff8153f180 000000000000fffa ffffffff817d8778 ffff88033fd47c38 ffffffff8153ef0d 0000000000000010 ffff88033fd47c48 ffff88033fd47be8 0000000000000000 0000000000000000 Call Trace: [] dump_stack+0x49/0x61 [] panic+0xbb/0x1d5 [] watchdog_overflow_callback+0xb1/0xc0 [] __perf_event_overflow+0x98/0x220 [] perf_event_overflow+0x14/0x20 [] intel_pmu_handle_irq+0x1de/0x3c0 [] ? unmap_kernel_range_noflush+0x11/0x20 [] ? ghes_copy_tofrom_phys+0xe5/0x200 [] perf_event_nmi_handler+0x34/0x60 [] nmi_handle+0x8a/0x170 [] default_do_nmi+0x68/0x210 [] do_nmi+0x90/0xe0 [] end_repeat_nmi+0x1e/0x2e [] ? skd_timer_tick_not_online+0x330/0x330 [skd] [] ? _raw_spin_lock_irqsave+0x21/0x30 [] ? _raw_spin_lock_irqsave+0x21/0x30 [] ? _raw_spin_lock_irqsave+0x21/0x30 <> [] skd_timer_tick+0x39/0x1e0 [skd] [] ? __queue_work+0x360/0x360 [] ? skd_timer_tick_not_online+0x330/0x330 [skd] [] call_timer_fn+0x48/0x120 [] run_timer_softirq+0x225/0x290 [] ? skd_timer_tick_not_online+0x330/0x330 [skd] [] __do_softirq+0xfc/0x2b0 [] ? tick_do_update_jiffies64+0x9f/0xd0 [] irq_exit+0xbd/0xd0 [] smp_apic_timer_interrupt+0x4a/0x5a [] apic_timer_interrupt+0x6a/0x70 [] ? cpuidle_enter_state+0xa0/0xd0 [] ? cpuidle_enter_state+0x5b/0xd0 [] cpuidle_idle_call+0xc7/0x160 [] arch_cpu_idle+0xe/0x30 [] cpu_idle_loop+0x9a/0x240 [] ? clockevents_register_device+0xc4/0x130 [] cpu_startup_entry+0x23/0x30 [] start_secondary+0x7a/0x80 Shutting down cpus with NMI Kernel Offset: 0x0 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffff9fffffff) ------------[ cut here ]------------ WARNING: CPU: 10 PID: 0 at arch/x86/kernel/smp.c:124 native_smp_send_reschedule+0x5f/0x70() Modules linked in: skd(O) dm_thin_pool(O) dm_bio_prison(O) dm_persistent_data(O) dm_bufio(O) libcrc32c ebtable_nat ebtables xt_CHECKSUM iptable_mangle bridge autofs4 target_core_iblock target_core_file target_core_pscsi target_core_mod configfs bnx2fc fcoe libfcoe 8021q libfc garp stp scsi_transport_fc llc scsi_tgt sunrpc cpufreq_ondemand ipt_REJECT nf_conntrack_ipv4 nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables bnx2i cnic uio ipv6 cxgb4i cxgb4 cxgb3i libcxgbi cxgb3 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi vhost_net macvtap macvlan vhost tun kvm_intel kvm iTCO_wdt iTCO_vendor_support microcode i2c_i801 lpc_ich mfd_core igb i2c_algo_bit i2c_core i7core_edac edac_core ixgbe dca ptp pps_core mdio ses enclosure sg acpi_cpufreq ext4 jbd2 mbcache sr_mod cdrom pata_acpi ata_generic ata_piix sd_mod crc_t10dif crct10dif_common dm_mirror dm_region_hash dm_log dm_mod megaraid_sas [last unloaded: skd] CPU: 10 PID: 0 Comm: swapper/10 Tainted: G W O 3.14.0-rc1.snitm+ #4 Hardware name: FUJITSU PRIMERGY RX300 S6 /D2619, BIOS 6.00 Rev. 1.10.2619.N1 05/24/2011 000000000000007c ffff88033fd478c0 ffffffff8153f180 000000000000007c 0000000000000000 ffff88033fd47900 ffffffff8104e9bc ffff88033fd52c40 ffff88033fc52c40 0000000000000002 ffff88033fd52c40 ffff8803329be250 Call Trace: [] dump_stack+0x49/0x61 [] warn_slowpath_common+0x8c/0xc0 [] warn_slowpath_null+0x1a/0x20 [] native_smp_send_reschedule+0x5f/0x70 [] trigger_load_balance+0x15e/0x200 [] scheduler_tick+0xa7/0xe0 [] update_process_times+0x61/0x80 [] ? apei_exec_write_register_value+0x1c/0x20 [] tick_sched_handle+0x39/0x80 [] tick_sched_timer+0x54/0x90 [] __run_hrtimer+0x7e/0x1c0 [] ? tick_nohz_handler+0xc0/0xc0 [] hrtimer_interrupt+0x10e/0x260 [] local_apic_timer_interrupt+0x3b/0x60 [] smp_apic_timer_interrupt+0x45/0x5a [] apic_timer_interrupt+0x6a/0x70 [] ? panic+0x192/0x1d5 [] ? panic+0xf0/0x1d5 [] watchdog_overflow_callback+0xb1/0xc0 [] __perf_event_overflow+0x98/0x220 [] perf_event_overflow+0x14/0x20 [] intel_pmu_handle_irq+0x1de/0x3c0 [] ? unmap_kernel_range_noflush+0x11/0x20 [] ? ghes_copy_tofrom_phys+0xe5/0x200 [] perf_event_nmi_handler+0x34/0x60 [] nmi_handle+0x8a/0x170 [] default_do_nmi+0x68/0x210 [] do_nmi+0x90/0xe0 [] end_repeat_nmi+0x1e/0x2e [] ? skd_timer_tick_not_online+0x330/0x330 [skd] [] ? _raw_spin_lock_irqsave+0x21/0x30 [] ? _raw_spin_lock_irqsave+0x21/0x30 [] ? _raw_spin_lock_irqsave+0x21/0x30 <> [] skd_timer_tick+0x39/0x1e0 [skd] [] ? __queue_work+0x360/0x360 [] ? skd_timer_tick_not_online+0x330/0x330 [skd] [] call_timer_fn+0x48/0x120 [] run_timer_softirq+0x225/0x290 [] ? skd_timer_tick_not_online+0x330/0x330 [skd] [] __do_softirq+0xfc/0x2b0 [] ? tick_do_update_jiffies64+0x9f/0xd0 [] irq_exit+0xbd/0xd0 [] smp_apic_timer_interrupt+0x4a/0x5a [] apic_timer_interrupt+0x6a/0x70 [] ? cpuidle_enter_state+0xa0/0xd0 [] ? cpuidle_enter_state+0x5b/0xd0 [] cpuidle_idle_call+0xc7/0x160 [] arch_cpu_idle+0xe/0x30 [] cpu_idle_loop+0x9a/0x240 [] ? clockevents_register_device+0xc4/0x130 [] cpu_startup_entry+0x23/0x30 [] start_secondary+0x7a/0x80 ---[ end trace 72a22a0dddd989d3 ]--- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/