Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751516AbaBMGLp (ORCPT ); Thu, 13 Feb 2014 01:11:45 -0500 Received: from 1.mo2.mail-out.ovh.net ([46.105.63.121]:47975 "EHLO mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750892AbaBMGLn (ORCPT ); Thu, 13 Feb 2014 01:11:43 -0500 MIME-Version: 1.0 In-Reply-To: <20140212210446.GF11498@piout.net> References: <1392199607-27452-1-git-send-email-jjhiblot@traphandler.com> <1392199607-27452-4-git-send-email-jjhiblot@traphandler.com> <20140212210446.GF11498@piout.net> Date: Thu, 13 Feb 2014 07:11:38 +0100 Message-ID: Subject: Re: [PATCH v4 3/8] at91: dt: Add at91sam9261 dt SoC support From: Jean-Jacques Hiblot To: Alexandre Belloni Cc: Jean-Jacques Hiblot , Nicolas Ferre , Jean-Christophe PLAGNIOL-VILLARD , boris brezillon , Gregory CLEMENT , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 X-Ovh-Tracer-Id: 7066992240636352536 X-Ovh-Remote: 209.85.160.49 (mail-pb0-f49.google.com) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrjedvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrkeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-02-12 22:04 GMT+01:00 Alexandre Belloni : > Sorry, one more comment on that patch: > > On 12/02/2014 at 11:06:42 +0100, Jean-Jacques Hiblot wrote : >> + pinctrl@fffff400 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "atmel,at91rm9200-pinctrl", "simple-bus"; >> + ranges = <0xfffff400 0xfffff400 0xa00>; >> + > I believe you got the range wrong, shouldn't it be: > ranges = <0xfffff400 0xfffff400 0x600>; > Yes you're right. Thanks for the review > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/