Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbaBMHlt (ORCPT ); Thu, 13 Feb 2014 02:41:49 -0500 Received: from mail-ve0-f176.google.com ([209.85.128.176]:46782 "EHLO mail-ve0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbaBMHlq (ORCPT ); Thu, 13 Feb 2014 02:41:46 -0500 MIME-Version: 1.0 In-Reply-To: <1392059868-8782-1-git-send-email-arend@broadcom.com> References: <1392059868-8782-1-git-send-email-arend@broadcom.com> From: Chen-Yu Tsai Date: Thu, 13 Feb 2014 15:41:25 +0800 X-Google-Sender-Auth: iq6jEr-lp8H0_0GLg6e5qdXRZPU Message-ID: Subject: Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices To: Arend van Spriel Cc: Rob Herring , devicetree , linux-kernel , Tomasz Figa Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2014 at 3:17 AM, Arend van Spriel wrote: > The Broadcom bcm43xx sdio devices are fullmac devices that may be > integrated in ARM platforms. Currently, the brcmfmac driver for > these devices support use of platform data. This patch specifies > the bindings that allow this platform data to be expressed in the > devicetree. > > Cc: Chen-Yu Tsai > Cc: Tomasz Figa > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Arend van Spriel > --- > This devicetree binding proposal is intended for platforms with > Broadcom wireless device in MMC sdio slot. These devices may > have their own interrupt and power line. Also the SDIO drive > strength is often hardware dependent and expressed in this > binding. Hi, I believe the interrupts and drive-strength properties are Ok. However, letting the platform driver power up the wifi chip does not guarantee proper ordering, does it? I mean, what if the MMC bus was probed before the (non-removable) chip was switched on? Being able to tie that to the mmc controller would be better IMO. I think this was discussed in Olof's "mmc: add support for power-on sequencing through DT" thread. Thanks! ChenYu > > Not sure if this should go in staging or not. Feel free to > comment on this proposal. > > Regards, > Arend -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/