Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S261415AbSKDRE0>; Mon, 4 Nov 2002 12:04:26 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S261563AbSKDRE0>; Mon, 4 Nov 2002 12:04:26 -0500
Received: from louise.pinerecords.com ([212.71.160.16]:62468 "EHLO
	louise.pinerecords.com") by vger.kernel.org with ESMTP
	id <S261415AbSKDREZ>; Mon, 4 Nov 2002 12:04:25 -0500
Date: Mon, 4 Nov 2002 18:10:55 +0100
From: Tomas Szepe <szepe@pinerecords.com>
To: Nikita Danilov <Nikita@Namesys.COM>
Cc: Alexander Zarochentcev <zam@Namesys.COM>, Hans Reiser <reiser@Namesys.COM>,
       lkml <linux-kernel@vger.kernel.org>, Oleg Drokin <green@Namesys.COM>,
       umka <umka@Namesys.COM>
Subject: Re: [BK][PATCH] Reiser4, will double Linux FS performance, pleaseapply
Message-ID: <20021104171055.GD8606@louise.pinerecords.com>
References: <200210312334.18146.Dieter.Nuetzel@hamburg.de> <3DC1B2FA.8010809@namesys.com> <3DC1D63A.CCAD78EF@digeo.com> <3DC1D885.6030902@namesys.com> <3DC1D9D0.684326AC@digeo.com> <3DC1DF02.7060307@namesys.com> <20021101102327.GA26306@louise.pinerecords.com> <15810.46998.714820.519167@crimson.namesys.com> <20021102133824.GL28803@louise.pinerecords.com> <15814.25070.118410.47102@laputa.namesys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <15814.25070.118410.47102@laputa.namesys.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2071
Lines: 55

>  > Hi,
>  > 
>  > Another one: trying to build 2.5.45 off a reiser4 mountpoint, I get:
>  > 
>  > reiser4[pdflush(7)]: flush_scan_extent (fs/reiser4/flush.c:3127)[nikita-2732]:
>  > WARNING: Flush raced against extent->tail
>  > reiser4[pdflush(7)]: jnode_flush (fs/reiser4/flush.c:1024)[jmacd-16739]:
>  > WARNING: flush failed: -11
>  > jnode_flush failed with err = -11
> 
> Can you please try the following patch to the fs/reiser4/flush.c:
> ----------------------------------------------------------------------
> --- /tmp/flush.c	Mon Nov  4 14:32:21 2002
> +++ flush.c	Mon Nov  4 14:32:32 2002
> @@ -3149,7 +3149,8 @@ flush_scan_extent(flush_scan * scan, int
>  				   only. Will be removed. */
>  				warning("nikita-2732", 
>  					"Flush raced against extent->tail");
> -				ret = -EAGAIN;
> +				scan->stop = 1;
> +				ret = 0;
>  				goto exit;
>  			}
>  			assert("jmacd-1230", item_is_extent(&scan->parent_coord));

Seems to fix the flush errors, however, I can still see the race warnings.
Worse though, at one point I stumbled upon the following:

$ df /ap
Filesystem           1k-blocks      Used Available Use% Mounted on
/dev/sda2              1490332 -73786976294838198272   1498808 101% /ap

This was right after I hit the reset button while compiling the kernel
off a reiser4 mountpoint, went on to finish the build after reboot and
then "rm -rf"'d the whole source tree (i.e. there was nothing on the
filesystem again).

reiser4.o is 20021031 plus the rmdir leak fix from this thread plus
your patch above.

>  > ... after which r4 crashes completely --
>  > Starts to hog all cpu time and umount() never goes through.
> 
> Try to wait a bit more and check whether any more "WARNING: Too many
> iterations" appear, OK?

Jup, now all I get is the race warnings.

-- 
tomas szepe <szepe@pinerecords.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/