Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753752AbaBMJsg (ORCPT ); Thu, 13 Feb 2014 04:48:36 -0500 Received: from vserver.eikelenboom.it ([84.200.39.61]:59304 "EHLO smtp.eikelenboom.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753065AbaBMJsd (ORCPT ); Thu, 13 Feb 2014 04:48:33 -0500 Date: Thu, 13 Feb 2014 10:48:24 +0100 From: Sander Eikelenboom Organization: Eikelenboom IT services X-Priority: 3 (Normal) Message-ID: <939539486.20140213104824@eikelenboom.it> To: Bjorn Helgaas CC: Konrad Rzeszutek Wilk , Tony Luck , Dave Airlie , Eiichiro Oiwa , Greg Kroah-Hartman , "linux-kernel @ vger . kernel . org" , "linux-pci @ vger . kernel . org" , Subject: Re: [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents it from reading it's own rom. It will get the content of the shadowrom at C000 instead, which is of the primary VGA card and the driver of the secondary card will bail out. In-Reply-To: <20140203145205.GB2992@phenom.dumpdata.com> References: <20140130000831.GJ16825@google.com> <1391160503-11122-1-git-send-email-linux@eikelenboom.it> <20140203145205.GB2992@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, I have given it another email and another week, but without gaining any reviewed or acked-by's. It seems the only way forward is to shovel it in linux-next earlier, give it a good soak and see if anyone starts to squeal .. or that everything seems to be ok :-) Would you need a v3 with the acked and reviewed-by from Konrad for x86 in it ? -- Sander Monday, February 3, 2014, 3:52:05 PM, you wrote: > On Fri, Jan 31, 2014 at 10:28:22AM +0100, Sander Eikelenboom wrote: >> Hi Bjorn / Tony, >> >> I fixed up ia64 as well and brought it inline again with the x86 code, >> but i don't have a ia64 machine, so that part is untested. >> Perhaps Tony is able to review/test it ? >> >> Sander >> >> >> >> Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary >> prevents it from reading it's own rom. It will get the content of the shadowrom >> at C000 instead, which is of the primary VGA card and the driver of the >> secondary card will bail out. >> >> Fix this by checking if the arch code or vga-arbitration has already >> determined the vga_default_device, if so only apply the fix to this >> primary video device and let the comment reflect this. >> >> v2: >> - Fix pci_fixup_video both in x86 and ia64 >> >> >> Sander Eikelenboom (1): >> Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the >> primary prevents it from reading it's own rom. It will get the >> content of the shadowrom at C000 instead, which is of the >> primary VGA card and the driver of the secondary card will bail >> out. > Your editor mutilated your subject line. It ought to have been just > one line. > Anyhow, you can also add 'Reviewed-by: Konrad Rzeszutek Wilk on the patch for the x86 part. > The ia64 "looks" OK to me, but my ia64 box won't boot v3.11 or later > so I can't give it a 'Tested-by' yet. >> >> arch/ia64/pci/fixup.c | 24 +++++++++++++----------- >> arch/x86/pci/fixup.c | 18 ++++++++++-------- >> 2 files changed, 23 insertions(+), 19 deletions(-) >> >> -- >> 1.7.10.4 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/