Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751008AbaBMOBm (ORCPT ); Thu, 13 Feb 2014 09:01:42 -0500 Received: from terminus.zytor.com ([198.137.202.10]:37402 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbaBMOBk (ORCPT ); Thu, 13 Feb 2014 09:01:40 -0500 Message-ID: <52FCD01F.70500@zytor.com> Date: Thu, 13 Feb 2014 06:01:03 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Matt Fleming CC: David Rientjes , Paul Gortmaker , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , x86@kernel.org Subject: Re: [PATCH] x86: fix two sparse warnings in early boot string handling References: <1392143619-11453-1-git-send-email-paul.gortmaker@windriver.com> <20140212020010.GB21033@windriver.com> <52FB8BEB.5020506@windriver.com> <52FB9807.40706@windriver.com> <52FBF5DD.3030407@windriver.com> <52FC0439.7020508@zytor.com> <20140213103109.GB20717@console-pimps.org> In-Reply-To: <20140213103109.GB20717@console-pimps.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2014 02:31 AM, Matt Fleming wrote: > On Wed, 12 Feb, at 03:31:05PM, H. Peter Anvin wrote: >> >> The real answer IMO ought to be that since arch/x86/boot/string.c is now >> used separately from boot.h (eboot.c which includes efi-stub-helper.c >> does *not* include boot.h) we may have to move those string functions >> into a separate header file. >> >> Matt, do you have any opinions here? > > This makes sense to me. Perhaps arch/x86/boot/lib/string.c which would > be useable by both arch/x86/boot/*.c and arch/x86/boot/compressed/*.c? > That would be fine, but the issue at hand isn't the .c file but the lack of a corresponding .h file... -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/