Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751735AbaBMQLZ (ORCPT ); Thu, 13 Feb 2014 11:11:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58467 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbaBMQLY (ORCPT ); Thu, 13 Feb 2014 11:11:24 -0500 Message-ID: <52FCEE9C.2040001@redhat.com> Date: Thu, 13 Feb 2014 11:11:08 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Weijie Yang , "'Mel Gorman'" CC: "'Andrew Morton'" , "'Minchan Kim'" , weijie.yang.kh@gmail.com, "'Linux-MM'" , "'linux-kernel'" Subject: Re: [PATCH 2/2] mm/vmscan: not check compaction_ready on promoted zones References: <000101cf2865$2a8411a0$7f8c34e0$%yang@samsung.com> In-Reply-To: <000101cf2865$2a8411a0$7f8c34e0$%yang@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2014 09:41 PM, Weijie Yang wrote: > We abort direct reclaim if find the zone is ready for compaction. > > Sometimes the zone is just a promoted highmem zone to force scan > pinning highmem, which is not the intended zone the caller want to > alloc page from. In this situation, setting aborted_reclaim to > indicate the caller turn back to retry allocation is waste of time > and could cause a loop in __alloc_pages_slowpath(). > > This patch do not check compaction_ready() on promoted zones to avoid > the above situation, only set aborted_reclaim if the caller intended > zone is ready to compaction. > > Signed-off-by: Weijie Yang Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/