Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbaBMSDH (ORCPT ); Thu, 13 Feb 2014 13:03:07 -0500 Received: from mout.gmx.net ([212.227.15.18]:61996 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbaBMSDD (ORCPT ); Thu, 13 Feb 2014 13:03:03 -0500 Date: Thu, 13 Feb 2014 19:02:46 +0100 From: rauchwolke@gmx.net To: Takashi Iwai Cc: Matthew Garrett , "david.henningsson@canonical.com" , "ibm-acpi-devel@lists.sourceforge.net" , "platform-driver-x86@vger.kernel.org" , "ibm-acpi@hmh.eng.br" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume In-Reply-To: References: <1392219165-20888-1-git-send-email-tiwai@suse.de> <1392237456.1201.2.camel@x230> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID: <0MGWR2-1W0rTh1wUC-00DE8E@mail.gmx.com> X-Provags-ID: V03:K0:R6kXkd7iJOAsIY9D9XA8XIP5CvSK81QVdS/RLMihLnDghFstKTZ Rj+UZ+eq03P9wJbNFMdGNaIlXhSpjbFtSIO5Ho/zJccEnL8hvQvMnBs5kcL3cFVWWbGI2xV mQg9sZCl3oSJXNzW7RZGNq6JQ/EXzpEmlTO8lj/PNIuwcDuzB1jciPXya4YsRWDXEvxDqrx apAOxQBNQDAt/wQ2FUwNA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, this patch doesn't work. The sound is now muted after the resume (light is on). But the userspace knows nothing about it. (kmix shows the volume as umuted) Peter On Thu, 13 Feb 2014 09:35:30 +0100 Takashi Iwai wrote: > At Wed, 12 Feb 2014 20:37:36 +0000, > Matthew Garrett wrote: > > > > On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > > > The mute LED states have to be restored after resume. > > > > Oh, never mind, we're not doing this through the LED class, are we? > > Good point. It seems that leds_class has pm_ops but it's enabled only > when a flag is set. > > I added the original bug reporter to Cc. (Don't know the name, > Bugzilla shows only the email address.) > Could you check the patch below works instead of the previous fix? > > > Takashi > > --- > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index defb6afc1409..16edf75d9c00 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -4796,6 +4796,7 @@ static struct tpacpi_led_classdev tpacpi_led_thinklight = { > .name = "tpacpi::thinklight", > .brightness_set = &light_sysfs_set, > .brightness_get = &light_sysfs_get, > + .flags = LED_CORE_SUSPENDRESUME, > } > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/